utils_net:Retry when not getting default gateway#4094
Closed
chloerh wants to merge 1 commit intoavocado-framework:masterfrom
Closed
utils_net:Retry when not getting default gateway#4094chloerh wants to merge 1 commit intoavocado-framework:masterfrom
chloerh wants to merge 1 commit intoavocado-framework:masterfrom
Conversation
smitterl
reviewed
Mar 27, 2025
| if p.get("dev") == target_iface | ||
| ] | ||
| default_route_list = non_multi + multi | ||
| LOG.debug(f"default_route_list: {default_route_list}") |
Contributor
There was a problem hiding this comment.
IIUC it's the first time we observe this so having to retry shouldn't be necessary but important here to stabilize our test runs. Therefore, would it make sense to LOG.warning or something similar whenever there wasn't a default route?
Signed-off-by: Haijiao Zhao <haizhao@redhat.com>
fb76f22 to
1cf1b3c
Compare
Contributor
Author
|
Close this pr since it's not solving the network issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test result: