Skip to content

libvirt_xml: add acpi and apic features to VMFeaturesXML #4330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dzhengfy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

libvirt_xml: add acpi and apic features to VMFeaturesXML #4330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions virttest/libvirt_xml/vm_xml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3844,6 +3844,8 @@ class VMFeaturesXML(base.LibvirtXMLBase):
"pmu",
"kvm_poll_control",
"ioapic",
"acpi",
"apic",
"kvm_dirty_ring_state",
"kvm_dirty_ring_size",
"ras",
Expand Down Expand Up @@ -3926,6 +3928,16 @@ def __init__(self, virsh_instance=base.virsh):
accessors.XMLElementDict(
property_name="ioapic", libvirtxml=self, parent_xpath="/", tag_name="ioapic"
)
accessors.XMLElementBool(
property_name="acpi",
libvirtxml=self,
parent_xpath="/",
tag_name="acpi")
accessors.XMLElementBool(
property_name="apic",
libvirtxml=self,
parent_xpath="/",
tag_name="apic")
Comment on lines +3931 to +3940
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The formatting of these XMLElementBool calls can be improved for better readability and consistency with PEP 8 style guidelines. When a function call is split across multiple lines, the closing parenthesis should be on a new line and aligned with the first character of the line that starts the multi-line construct.

        accessors.XMLElementBool(
            property_name="acpi",
            libvirtxml=self,
            parent_xpath="/",
            tag_name="acpi",
        )
        accessors.XMLElementBool(
            property_name="apic",
            libvirtxml=self,
            parent_xpath="/",
            tag_name="apic",
        )
References
  1. According to PEP 8, for multi-line constructs, the closing bracket/brace/parenthesis should be on a new line, aligned with the first character of the line that starts the multi-line construct. (link)

accessors.XMLAttribute(
property_name="kvm_dirty_ring_state",
libvirtxml=self,
Expand Down
Loading