Skip to content

libvirt_version: Add session parameter to is_libvirt_feature_supported #4331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hholoubk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

libvirt_version: Add session parameter to is_libvirt_feature_supported #4331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions virttest/libvirt_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,15 @@ def version_compare(major, minor, update, session=None):
return False


def is_libvirt_feature_supported(params, ignore_error=False):
def is_libvirt_feature_supported(params, ignore_error=False, session=None):
"""
Check whether the function is supported in this libvirt version by comparing
the installed libvirt version

:param params: Dictionary with the test parameters
:param ignore_error: Whether to raise an exception
:param session: Shell session on remote host. When provided, the version
check is performed on the remote host instead of locally.
:raise: When ignore_error is set False, raise TestCancel if the feature is
not supported
:return: True if the feature is supported;
Expand All @@ -97,7 +99,7 @@ def is_libvirt_feature_supported(params, ignore_error=False):
)

if func_supported_since_libvirt_ver:
if not version_compare(*func_supported_since_libvirt_ver):
if not version_compare(*func_supported_since_libvirt_ver, session=session):
if ignore_error:
LOG.error(unsupported_err_msg)
return False
Expand Down
Loading