Skip to content

libvirt_pcicontr: add func for pcie-root#4334

Draft
dzhengfy wants to merge 1 commit intoavocado-framework:masterfrom
dzhengfy:add_get_pcie_root_ctl
Draft

libvirt_pcicontr: add func for pcie-root#4334
dzhengfy wants to merge 1 commit intoavocado-framework:masterfrom
dzhengfy:add_get_pcie_root_ctl

Conversation

@dzhengfy
Copy link
Copy Markdown
Contributor

@dzhengfy dzhengfy commented Mar 8, 2026

No description provided.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new helper function designed to streamline the process of identifying the PCIe root controller in a virtual machine's Libvirt XML definition. This enhancement aims to simplify subsequent operations that require interaction with or information about the primary PCIe bus, improving the utility's robustness when dealing with PCI device management.

Highlights

  • New Utility Function: Added a new function, get_pcie_root, to libvirt_pcicontr.py which is responsible for finding and returning the index of the pcie-root controller within a virtual machine's XML configuration. If not found, it logs a warning and returns -1.
Changelog
  • virttest/utils_libvirt/libvirt_pcicontr.py
    • Added get_pcie_root function to locate the index of the pcie-root controller in VM XML.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new utility function get_pcie_root to find the pcie-root controller in a VM's XML definition. The implementation has a potential bug where it returns the list index instead of the controller's XML index attribute. I've suggested a fix to correct this and to make the loop more Pythonic.

Signed-off-by: Dan Zheng <dzheng@redhat.com>
@dzhengfy dzhengfy force-pushed the add_get_pcie_root_ctl branch from aa5d505 to 0cbd641 Compare March 8, 2026 23:39
@avocado-framework avocado-framework deleted a comment from gemini-code-assist Bot Mar 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant