Improve the detection logic of utils_net.get_dhcp_client

[yanglei-rh]

Remove host distro check, because there is no necessary correlation between the host version and the guest version

ID: LIBVIRTAT-22359
Signed-off-by: Lei Yang leiyang@redhat.com

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the DHCP client detection mechanism within the virttest utility. It removes an unnecessary dependency on the host operating system's distribution and version, which previously influenced the selection of DHCP clients. By streamlining this logic, the detection becomes more reliable and independent of the host environment, ensuring a more consistent approach to identifying available DHCP clients.

Highlights

• DHCP Client Detection Logic: Removed the host distribution check (RHEL version 10 or higher) from the get_dhcp_client function, as the host's OS version is not relevant to the guest's DHCP client.
• DHCP Client Priority: Reordered the dhcp_clients list to prioritize dhcpcd over dhclient during detection.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request improves the DHCP client detection logic in get_dhcp_client. The previous implementation incorrectly determined the guest's DHCP client based on the host's distribution. This change removes the faulty logic and replaces it with a more robust approach that checks for available DHCP clients (dhcpcd then dhclient) directly within the guest environment. The change is correct and well-implemented.

[yanglei-rh]

Hi @Yingshun @quanwenli Could you please help me review this patch? Thanks a lot.

[Yingshun]

@yanglei-rh Please upload test results, thx!

[quanwenli]

@yanglei-rh We did a similar MR before to fix this issue #4320

[yanglei-rh]

@yanglei-rh We did a similar MR before to fix this issue #4320

Hi @quanwenli Thanks for help update, let me close this pr as duplicate.