Honor malloc_perturb from vt config#4356
Open
bssrikanth wants to merge 1 commit intoavocado-framework:masterfrom
Open
Honor malloc_perturb from vt config#4356bssrikanth wants to merge 1 commit intoavocado-framework:masterfrom
bssrikanth wants to merge 1 commit intoavocado-framework:masterfrom
Conversation
If a VT config file is supplied, leave malloc_perturb to the cfg and log that vt.qemu.malloc_perturb is ignored. Signed-off-by: Srikanth Aithal <srikanth.aithal@amd.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the _process_malloc_perturb method in avocado_vt/options.py to conditionally assign the malloc_perturb setting. It now checks for the presence of a general configuration via vt.config and skips the assignment if one is found, logging the action instead. I have no feedback to provide as no review comments were submitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a VT config file is supplied, leave malloc_perturb to the cfg and log that vt.qemu.malloc_perturb is ignored.