skip -bios when IGVM supplies guest firmware#4357
Open
bssrikanth wants to merge 1 commit intoavocado-framework:masterfrom
Open
skip -bios when IGVM supplies guest firmware#4357bssrikanth wants to merge 1 commit intoavocado-framework:masterfrom
bssrikanth wants to merge 1 commit intoavocado-framework:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies virttest/qemu_vm.py to prevent the inclusion of the -bios parameter when IGVM is enabled, avoiding potential firmware conflicts. A review comment suggests using get_boolean for the enable_igvm parameter to more robustly handle various truthy values like "on" or "true" instead of a strict string comparison with "yes".
Only insert the -bios StrDev when bios_path is set and enable_igvm is not yes. Signed-off-by: Srikanth Aithal <srikanth.aithal@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only insert the -bios StrDev when bios_path is set and enable_igvm is not yes.