adding relevant nmcli command based on if_type #6151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch takes care of the following : - Using nmcli type ethernet / bond for creating config files based on NetworkInterface if_type. - Setting the flags to true when required. distro_is_rhel9_or_later = True distro_is_suse16_or_later = True Signed-off-by: Vaishnavi Bhat <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6151 +/- ##
==========================================
- Coverage 68.25% 68.24% -0.02%
==========================================
Files 204 204
Lines 22121 22126 +5
==========================================
+ Hits 15099 15100 +1
- Misses 7022 7026 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
richtja
requested changes
Apr 22, 2025
There was a problem hiding this comment.
Hi @vaishnavibhat, can you please address the static-checks failure in our CI? Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch takes care of the following :
distro_is_suse16_or_later = True