fix: restore Download button single-click (#1309)#1319
Open
echopi wants to merge 1 commit intoavwo:masterfrom
Open
fix: restore Download button single-click (#1309)#1319echopi wants to merge 1 commit intoavwo:masterfrom
echopi wants to merge 1 commit intoavwo:masterfrom
Conversation
The dark mode refactoring (0ae2073) accidentally removed className="w-download" from the Download <a> elements. The showNameInput handler checks this class to decide whether to show the filename input dialog. Without it, single-click download was broken (showed key input instead of filename input). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
echopi
force-pushed
the
fix/download-button-1309
branch
from
5b3c160 to
e9db448
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0ae2073) 意外删除了className="w-download"，导致showNameInput无法识别点击来源Changes
biz/webui/htdocs/src/js/textarea.js: 恢复className="w-download"biz/webui/htdocs/src/js/json-viewer.js: 同上Root cause
showNameInput通过/w-download/.test(e.target.className)判断是否显示文件名输入框。没有这个 class，单击 Download 会错误地显示 Key 输入框而非文件名输入框。Test plan
🤖 Generated with Claude Code