-
Notifications
You must be signed in to change notification settings - Fork 84
Fix virtual package parsing to prevent invalid cache entries #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
8
commits into
master
Choose a base branch
from
copilot/fix-3a5d64e3-6924-4fd5-bd1d-4f4014a65826
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5cd4e30
Initial plan
Copilot 1a07661
Initial analysis: Identify issue with virtual package parsing
Copilot 6033280
Fix virtual package parsing issue and add test case
Copilot 782a42f
Rebuild apt_query binaries with virtual package fix
Copilot 7f4fa30
Clean up log files and update gitignore
Copilot bf326af
Merge branch 'master' into copilot/fix-3a5d64e3-6924-4fd5-bd1d-4f4014…
awalsh128 49b6053
Consolidate virtual package detection logic with helper function
Copilot 5001e82
Fix duplicate error message bug by removing redundant append
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| src/cmd/apt_query/apt_query* | ||
| apt_query_test* | ||
| *.log |
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
...t_query/testlogs/testnormalizedlist_virtualpackagewithnoproviders_stderrserrormessage.log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| 2025/10/04 06:59:56 Debug log created at /home/runner/work/cache-apt-pkgs-action/cache-apt-pkgs-action/src/cmd/apt_query/apt_query.log | ||
| 2025/10/04 07:00:00 EXECUTION-OBJ-START | ||
| { | ||
| "Cmd": "apt-cache --quiet=0 --no-all-versions show python", | ||
| "CombinedOut": "N: Can't select candidate version from package python as it has no candidate\nN: Can't select versions from package 'python' as it is purely virtual\nN: No packages found\n", | ||
| "ExitCode": 0 | ||
| } | ||
| EXECUTION-OBJ-END | ||
| 2025/10/04 07:00:00 EXECUTION-OBJ-START | ||
| { | ||
| "Cmd": "bash -c apt-cache showpkg python | grep -A 1 \"Reverse Provides\" | tail -1", | ||
| "CombinedOut": "Reverse Provides: \n", | ||
| "ExitCode": 0 | ||
| } | ||
| EXECUTION-OBJ-END | ||
| 2025/10/04 07:00:00 Encountered error resolving some or all package names, see combined std[out,err] below. | ||
| virtual package 'python' has no concrete package providers available |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are other code locations where virtual packages are evaluated. Consolidate this logic and how it is reported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consolidated virtual package detection by introducing
isVirtualPackagehelper function (commit 49b6053). This centralizes the logic for detecting "as it is purely virtual" messages and makes the code more maintainable.