RFC: Stop unfocused clients by blueyed · Pull Request #111 · awesomeWM/awesome-www

blueyed · 2017-08-22T21:38:29Z

TODO:

support/use cgroup freezer? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/cgroup-v1/freezer-subsystem.txt

Resources:

https://vermaden.wordpress.com/2018/09/19/freebsd-desktop-part-16-configuration-pause-any-application/ (via https://news.ycombinator.com/item?id=18022540)

psychon

What kind of things do you do with Thunderbird and Firefox that you want to SIGSTOP them so much? :-(

psychon · 2017-08-23T07:48:17Z

+function stop_unfocused.sigstop(c)
+  if c.pid then
+    awesome.kill(c.pid, 19)
+    awful.spawn('pkill -STOP -g ' .. c.pid)


Hm. :-(
What is this needed for? Which programs (which make sure they are always their process group leader) have "evil stuff" in their group? I doubt a lot that this works reliably and only happens to work accidentally for things started from a shell.
Also: { "pkill", "-STOP", "-g", tostring(c.pid) }

IIRC this was needed for qutebrowser.
Will double-check.

Of course, WebKit uses child processes nowadays (to everyone reading this: And if your webkit version does not, you might have quite an ancient version of a browser engine, which is never a good sign).

Feel free to do something with the following:

diff --git a/luaa.c b/luaa.c index 2bd5e30..662146a 100644 --- a/luaa.c +++ b/luaa.c @@ -254,7 +254,9 @@ luaA_restart(lua_State *L) /** Send a signal to a process identified by its process id. See * `awesome.unix_signal` for a list of signals. - * @tparam integer pid Process identifier + * @tparam integer pid Either a process identifier, `0` for awesome's process + * group, `-1` for all processes, or `-pgid` for all processes in the process group + * `pgid`. See `man 3 kill` for details. * @tparam integer sig Signal number * @treturn boolean true if the signal was successfully sent, else false * @function kill @@ -262,7 +264,7 @@ luaA_restart(lua_State *L) static int luaA_kill(lua_State *L) { - int pid = luaA_checknumber_range(L, 1, 1, INT_MAX); + int pid = luaL_checkinteger(L, 1); int sig = luaA_checknumber_range(L, 2, 0, INT_MAX); int result = kill(pid, sig);

JFI: Using awesome.kill with a negative pgid works quite good by itself now, but I've noticed an issue with Thunderbird, where child processes are in the same process group then (https://bugzilla.mozilla.org/show_bug.cgi?id=1517425). This is relevant for when handling both Thunderbird and qutebrowser, and the browser was started from Thunderbird. In this case stopping either of them would also stop the other.

psychon · 2017-08-23T07:48:42Z

+  stop_timeout = 10,
+}
+
+stop_unfocused.ignore_clients = {}


Shouldn't this table have weak keys so that clients are not prevented from being GC'd?

Makes sense.. do you have some pointer?
It could also get removed on unmanage?!

stop_unfocused.ignore_clients = setmetatable({}, { __mode = "k" })

psychon · 2017-08-23T07:49:25Z

+      stop_unfocused.sigcont(c)
+    else
+      timer.start_new(0.05, function()
+        timer.delayed_call(function() delayed_cont(c, coords) end)


timer.delayed_call(delayed_cont, c, coords)

psychon · 2017-08-23T07:51:49Z

+end)
+
+-- Restart any stopped clients when exiting/restarting.
+awesome.connect_signal("exit", function(restarting)  -- luacheck: no unused args


Just remove the unused parameter restarting and the luacheck comment.

Done.
Somehow I've imagined it to be better to copy/see the function signature.

psychon · 2017-08-23T07:53:49Z

+  end
+end
+local sigstop_unfocus = function(c)
+  if c.pid and not sigstopped_clients[c] and not c.ontop and not stop_unfocused.ignore_clients[c] then


Can't this "ignore ontop" be moved into a rule? Perhaps timeout = false means to ignore such a client, or something like that?

psychon · 2017-08-23T07:55:08Z

+      if timeout then
+        if sigstop_timers[c] then
+          sigstop_timers[c]:stop()
+        end


Can this happen? Such a timer is only started when a client is unfocused and a client cannot be unfocused twice in a row (without being focused in between, in which case the focus-callback stops the timer).

psychon · 2017-08-23T07:55:49Z

+          sigstop_timers[c]:stop()
+        end
+        sigstop_timers[c] = timer.start_new(timeout, function()
+          if c ~= client.focus and c.pid ~= client.focus.pid then


This needs a c.valid check somewhere.

psychon · 2017-08-23T07:56:09Z

+end
+
+local function delayed_cont(c, mouse_coords)
+  if client.focus == c then


This needs to be c.valid and client.focus == c.

[ci skip]

blueyed · 2017-08-23T09:34:27Z

What kind of things do you do with Thunderbird and Firefox that you want to SIGSTOP them so much? :-(

Browsers tend to use a lot of resources (CPU) even when not being used actively - which depends on your open tabs, of course.
One very bad website in this regard seems to be Travis CI (where it seems to depend on the number of repos they are polling in the background all the time).

blueyed · 2018-09-21T16:27:47Z

Need to come back to this (but am using a very modified version still).

Just wanted to leave this for reference: https://vermaden.wordpress.com/2018/09/19/freebsd-desktop-part-16-configuration-pause-any-application/ (via https://news.ycombinator.com/item?id=18022540).

Conflicts: recipes.mdwn

This is necessary for when multiple clients are involved, e.g. qutebrowser windows, and custom callbacks are used.

For awesomeWM/awesome-www#111.

Ref: awesomeWM/awesome#2895 (comment)

blueyed force-pushed the stop_unfocused branch from 116cba2 to 6fae634 Compare August 22, 2017 21:42

psychon requested changes Aug 23, 2017

View reviewed changes

blueyed added 3 commits August 23, 2017 11:31

RFC: Stop unfocused clients

f1fa863

fixup! RFC: Stop unfocused clients

343da71

[ci skip]

fixup! fixup! RFC: Stop unfocused clients

2de3aa0

blueyed force-pushed the stop_unfocused branch from 6fae634 to 2de3aa0 Compare August 23, 2017 09:32

blueyed mentioned this pull request Aug 24, 2017

QtWebEngine processes should get stopped on SIGSTOP qutebrowser/qutebrowser#2922

Closed

blueyed mentioned this pull request Oct 21, 2017

Handle X11 selection for stopped clients hluk/CopyQ#821

Closed

blueyed added 5 commits September 21, 2018 19:10

Merge remote-tracking branch 'origin/master' into stop_unfocused

894bb65

Conflicts: recipes.mdwn

WIP

c6084b2

fixup! RFC: Stop unfocused clients

fcbd8c3

Handle clients by PID (sigstopped_pids)

661e828

This is necessary for when multiple clients are involved, e.g. qutebrowser windows, and custom callbacks are used.

doc: add example with custom callbacks for qutebrowser

9b2a923

blueyed mentioned this pull request Feb 16, 2019

Add selection getter objects awesomeWM/awesome#2639

Merged

blueyed added a commit to blueyed/dotfiles that referenced this pull request Mar 7, 2019

firefox/thunderbird: send SIGCONT

9216ebe

For awesomeWM/awesome-www#111.

blueyed added 9 commits March 7, 2020 21:49

recipes/stop_unfocused.lua: index (WIP)

79d9e2f

recipes/stop_unfocused.lua: WIP/refactor/cleanup

4d26257

recipes.mdwn: reword

cd6e1a6

recipes/stop_unfocused.mdwn: section "Temporarily ignore clients"

2c6078b

Fix get_pids_for_kill_stop_cb for bash

15def61

Clean up get_pids_for_kill_stop_cb cmd

2812828

class=firefox for Firefox

196ace6

Use local get_props_and_callbacks

8a0a547

Ref: awesomeWM/awesome#2895 (comment)

fixup! Clean up get_pids_for_kill_stop_cb cmd

3003dbb

Uh oh!

Conversation

blueyed commented Aug 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

psychon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blueyed commented Aug 23, 2017

Uh oh!

blueyed commented Sep 21, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

blueyed commented Aug 22, 2017 •

edited

Loading