feat(climate): add hvac temperature presets

- add HVAC preset utilities and settings dialog coverage
- refine dashboard card config and security tests
- align commit-message docs and hook validation with Conventional Commits 1.0.0
- move Vite chunking helpers under scripts

Author: awesomestvi

AGENTS.md

@@ -7,15 +7,23 @@ Connects to Home Assistant over WebSocket.
 
 ## Commit Rules
 
-- Use [Conventional Commits](https://www.conventionalcommits.org/) format: `type(scope): summary`
-- Valid types: `feat`, `fix`, `refactor`, `docs`, `test`, `chore`, `build`, `ci`, `perf`, `style`
-- Summary must be lowercase, imperative mood, no period at the end
-- Do not use generic or free-form commit messages
-- Include a concise bullet-point body for meaningful changes so the project can track what changed between releases
-- Keep bullet lists contiguous in the commit body. Do not create each bullet as a separate `git commit -m` paragraph, because that inserts blank lines between items.
-- Keep commit bodies focused on user-visible behavior, architecture, tests, docs, or operational impact
-- Trivial commits such as formatting-only or metadata-only changes may omit the body
-- Do not use `git commit --no-verify` unless the user explicitly approves skipping hooks for that commit
+- Follow the [Conventional Commits 1.0.0 specification](https://www.conventionalcommits.org/en/v1.0.0/#specification).
+- Use this structure:
+  ```text
+  <type>[optional scope][optional !]: <description>
+
+  [optional body]
+
+  [optional footer(s)]
+  ```
+- `feat` means the commit adds a new feature.
+- `fix` means the commit fixes a bug.
+- Other types are allowed when they describe the change clearly, such as `build`, `chore`, `ci`, `docs`, `perf`, `refactor`, `style`, or `test`.
+- A scope may be added after the type to identify the affected area, for example `feat(dashboard): add room filters`.
+- The description must immediately follow the colon and space, and should be a concise summary of the change.
+- A body may be added after one blank line when the change needs extra context. The body is free-form and may contain multiple paragraphs.
+- Footers may be added after one blank line following the body. Use git-trailer style tokens such as `Refs: #123` or `Reviewed-by: Name`.
+- Breaking changes must be marked either with `!` before the colon, such as `feat(api)!: remove legacy auth`, or with a footer that starts with `BREAKING CHANGE:`.
 
 ---
 

CONTRIBUTING.md

@@ -181,16 +181,13 @@ source of truth for the production `pnpm build` step.
 
 ### Commit Messages
 
-Follow [Conventional Commits](https://www.conventionalcommits.org/):
+Follow [Conventional Commits 1.0.0](https://www.conventionalcommits.org/en/v1.0.0/#specification):
 
-- Format: `type(scope): summary`
-- `feat:` - New feature
-- `fix:` - Bug fix
-- `docs:` - Documentation changes
-- `style:` - Code style changes (formatting, etc.)
-- `refactor:` - Code refactoring
-- `test:` - Adding or updating tests
-- `chore:` - Maintenance tasks
+- Format: `<type>[optional scope][optional !]: <description>`
+- `feat` commits add a new feature.
+- `fix` commits fix a bug.
+- Other clear types are allowed, such as `build`, `chore`, `ci`, `docs`, `perf`, `refactor`, `style`, and `test`.
+- Breaking changes use `!` before the colon or a `BREAKING CHANGE:` footer.
 
 Version bumps follow the beta semver policy in [docs/VERSIONING.md](docs/VERSIONING.md). While Navet is in beta, prefer `0.x.y` and `0.x.y-beta.n` over `1.0.0`.
 
@@ -199,8 +196,7 @@ Examples:
 feat(calendar): add source selection to card settings
 fix(search): match Home Assistant entity-id queries
 docs(readme): update appearance and search behavior
-style(settings): tighten preview card spacing
-refactor(lighting): share light card surface tokens
+refactor(lighting)!: replace legacy light state mapping
 ```
 
 ### Pre-commit Hooks
@@ -210,7 +206,7 @@ Navet uses Husky hooks in `.husky/`. `pnpm install` runs the `prepare` script an
 The current hook split is:
 
 - `commit-msg`
-  - enforces the Conventional Commit format: `type(scope): summary`
+  - enforces the Conventional Commits header format: `<type>[optional scope][optional !]: <description>`
 - `pre-commit`
   - `pnpm check:lockfile` to keep `package.json` and `pnpm-lock.yaml` in sync
   - `pnpm check` for Biome lint/format issues

README.md

@@ -287,7 +287,7 @@ when to run those locally.
 Navet uses Conventional Commits:
 
 ```text
-type(scope): summary
+<type>[optional scope][optional !]: <description>
 ```
 
 When contributing:

scripts/check-commit-message.mjs

@@ -1,8 +1,6 @@
 import fs from 'node:fs';
 import process from 'node:process';
 
-const COMMIT_TYPES = ['feat', 'fix', 'refactor', 'docs', 'test', 'chore', 'build', 'ci', 'perf', 'style'];
-const FIRST_LINE_LIMIT = 72;
 const messageFile = process.argv[2];
 
 if (!messageFile) {
@@ -11,36 +9,28 @@ if (!messageFile) {
 }
 
 const message = fs.readFileSync(messageFile, 'utf8');
-const firstLine = message.split(/\r?\n/, 1)[0]?.trim() ?? '';
+const lines = message.replace(/\r\n/g, '\n').split('\n');
+const firstLine = lines[0]?.trim() ?? '';
 
 if (firstLine.length === 0) {
   console.error('Commit message is empty.');
   process.exit(1);
 }
 
-if (firstLine.length > FIRST_LINE_LIMIT) {
-  console.error(
-    `Commit summary must be ${FIRST_LINE_LIMIT} characters or fewer. Got ${firstLine.length}.`
-  );
-  process.exit(1);
-}
-
-const conventionalCommitPattern = new RegExp(
-  `^(${COMMIT_TYPES.join('|')})(\\([a-z0-9][a-z0-9-]*\\))?: [a-z0-9][a-z0-9 /,&+()-]*[a-z0-9)]$`
-);
+const conventionalCommitPattern =
+  /^(?<type>[a-zA-Z0-9-]+)(?<scope>\([^)()\r\n]+\))?(?<breaking>!)?: (?<description>.+)$/;
 
 if (!conventionalCommitPattern.test(firstLine)) {
   console.error(
-    'Commit message must match `type(scope): summary` using a supported type and lowercase summary.'
+    'Commit message must match Conventional Commits: `<type>[optional scope][optional !]: <description>`.'
   );
-  console.error(`Supported types: ${COMMIT_TYPES.join(', ')}`);
   console.error(`Received: ${firstLine}`);
   process.exit(1);
 }
 
-if (firstLine.endsWith('.')) {
-  console.error('Commit summary must not end with a period.');
+if (lines.length > 1 && lines[1] !== '') {
+  console.error('Commit body or footers must be separated from the header by one blank line.');
   process.exit(1);
 }
 
-console.log('Commit message format looks good.');
+console.log('Commit message follows Conventional Commits.');

build/vite-chunking.test.ts scripts/vite-chunking.test.tsbuild/vite-chunking.test.ts renamed to scripts/vite-chunking.test.ts

@@ -280,6 +280,7 @@ export const HVACCard = memo(function HVACCard({
           mode={controller.mode}
           targetTemp={controller.targetTemp}
           currentTemp={controller.currentTemp}
+          sourceTemperatureUnit={temperatureUnit}
           minTemp={controller.minTemp}
           maxTemp={controller.maxTemp}
           step={controller.step}

build/vite-chunking.ts scripts/vite-chunking.tsbuild/vite-chunking.ts renamed to scripts/vite-chunking.ts

@@ -3,6 +3,8 @@ import { CardActionRow, CardActionRowGroup } from '@/app/components/patterns/car
 import { CardSettingsActionButton } from '@/app/components/shared/card-settings-action-button';
 import { cn } from '@/app/components/ui/utils';
 import type { ThemeType } from '@/app/hooks';
+import { formatTemperatureValueFromSourceUnit } from '@/app/utils/temperature';
+import { convertCelsiusPresetToSourceUnit } from '../../../utils/hvac-temperature-presets';
 import { HVACModeControls } from '../hvac-mode-controls';
 import { HVACTempControls } from '../hvac-temp-controls';
 import type { HVACCardController } from '../use-hvac-card-controller';
@@ -53,15 +55,19 @@ export const HVACCardLargeLayout = memo(function HVACCardLargeLayout({
         <div className="mt-auto">
           <div className="mb-4 flex max-w-[72%] items-center gap-1.5">
             {TEMPERATURE_PRESETS.map((preset) => {
-              const isSelected = Math.abs(controller.targetTemp - preset) < 0.05;
+              const sourcePresetValue = convertCelsiusPresetToSourceUnit(
+                preset,
+                controller.sourceTemperatureUnit
+              );
+              const isSelected = Math.abs(controller.targetTemp - sourcePresetValue) < 0.05;
 
               return (
                 <button
                   type="button"
                   key={preset}
                   onClick={(event) => {
                     event.stopPropagation();
-                    controller.commitTargetTemp(preset);
+                    controller.commitTargetTemp(sourcePresetValue);
                   }}
                   className={cn(
                     'relative z-[3] min-w-[4.5rem] rounded-2xl border px-3 py-2 text-sm font-semibold transition-all',
@@ -73,7 +79,12 @@ export const HVACCardLargeLayout = memo(function HVACCardLargeLayout({
                     color: isSelected ? readableTokens.titleColor : readableTokens.subtitleColor,
                   }}
                 >
-                  {controller.formatTemperatureValue(preset)}°
+                  {formatTemperatureValueFromSourceUnit(
+                    sourcePresetValue,
+                    controller.sourceTemperatureUnit,
+                    controller.temperatureUnit
+                  )}
+                  °
                 </button>
               );
             })}

src/app/features/climate/components/hvac-card/index.tsx

@@ -380,6 +380,7 @@ export function useHVACCardController({
     step: temperatureRange.step,
     targetTemp,
     temperatureUnit,
+    sourceTemperatureUnit,
     textColor,
     theme,
   };

src/app/features/climate/components/hvac-card/layouts/hvac-card-large-layout.tsx

@@ -0,0 +1,117 @@
+import { fireEvent, screen } from '@testing-library/react';
+import { beforeEach, describe, expect, it, vi } from 'vitest';
+import { useSettingsStore } from '@/app/stores/settings-store';
+import { renderWithProviders } from '@/test/render';
+import { HVACSettingsDialog } from '../index';
+import type { HVACSettingsDialogProps } from '../types';
+
+function renderDialog(overrides: Partial<HVACSettingsDialogProps> = {}) {
+  const props: HVACSettingsDialogProps = {
+    entityId: 'climate.hallway',
+    isOpen: true,
+    onOpenChange: vi.fn(),
+    name: 'Hallway',
+    isOn: true,
+    mode: 'heat',
+    targetTemp: 72,
+    currentTemp: 70,
+    sourceTemperatureUnit: 'fahrenheit',
+    minTemp: 60,
+    maxTemp: 86,
+    step: 1,
+    supportedHvacModes: ['heat', 'cool', 'off'],
+    onModeChange: vi.fn(),
+    onTargetTempChange: vi.fn(),
+    onTargetTempCommit: vi.fn(),
+    ...overrides,
+  };
+
+  renderWithProviders(<HVACSettingsDialog {...props} />);
+  return props;
+}
+
+describe('HVACSettingsDialog', () => {
+  beforeEach(() => {
+    useSettingsStore.setState({ temperatureUnit: 'fahrenheit' });
+  });
+
+  it('keeps Fahrenheit source temperatures unchanged when Navet display is Fahrenheit', () => {
+    const props = renderDialog();
+
+    expect(screen.getByRole('slider')).toHaveAttribute('aria-valuenow', '72');
+    expect(screen.getByText('70°F')).toBeInTheDocument();
+    expect(screen.queryByText('162')).not.toBeInTheDocument();
+    expect(screen.queryByText('Current 158°F')).not.toBeInTheDocument();
+
+    fireEvent.click(screen.getByLabelText('Increase temperature'));
+
+    expect(props.onTargetTempCommit).toHaveBeenCalledWith(73);
+  });
+
+  it('renders Celsius comfort presets as Fahrenheit display values and commits Fahrenheit source values', () => {
+    const props = renderDialog();
+
+    expect(screen.queryByRole('button', { name: '18°' })).not.toBeInTheDocument();
+    expect(screen.queryByRole('button', { name: '21°' })).not.toBeInTheDocument();
+    expect(screen.queryByRole('button', { name: '24°' })).not.toBeInTheDocument();
+    expect(screen.getByRole('button', { name: '64°' })).toBeInTheDocument();
+    expect(screen.getByRole('button', { name: '70°' })).toBeInTheDocument();
+    expect(screen.getByRole('button', { name: '75°' })).toBeInTheDocument();
+
+    fireEvent.click(screen.getByRole('button', { name: '70°' }));
+
+    expect(props.onTargetTempCommit).toHaveBeenCalledWith(expect.closeTo(69.8));
+  });
+
+  it('converts Fahrenheit source temperatures when Navet display is Celsius', () => {
+    useSettingsStore.setState({ temperatureUnit: 'celsius' });
+    const props = renderDialog();
+
+    expect(Number(screen.getByRole('slider').getAttribute('aria-valuenow'))).toBeCloseTo(22.222);
+    expect(screen.getByText('21.1°C')).toBeInTheDocument();
+    expect(screen.queryByText('70°F')).not.toBeInTheDocument();
+
+    fireEvent.click(screen.getByLabelText('Increase temperature'));
+
+    expect(props.onTargetTempCommit).toHaveBeenCalledWith(expect.closeTo(73));
+  });
+
+  it('keeps Celsius source temperatures unchanged when Navet display is Celsius', () => {
+    useSettingsStore.setState({ temperatureUnit: 'celsius' });
+    const props = renderDialog({
+      targetTemp: 22,
+      currentTemp: 21,
+      sourceTemperatureUnit: 'celsius',
+      minTemp: 16,
+      maxTemp: 30,
+      step: 0.5,
+    });
+
+    expect(screen.getByRole('slider')).toHaveAttribute('aria-valuenow', '22');
+    expect(screen.getByText('21°C')).toBeInTheDocument();
+    expect(screen.queryByText('69.8°F')).not.toBeInTheDocument();
+
+    fireEvent.click(screen.getByLabelText('Increase temperature'));
+
+    expect(props.onTargetTempCommit).toHaveBeenCalledWith(22.5);
+  });
+
+  it('converts Celsius source temperatures when Navet display is Fahrenheit', () => {
+    const props = renderDialog({
+      targetTemp: 22,
+      currentTemp: 21,
+      sourceTemperatureUnit: 'celsius',
+      minTemp: 16,
+      maxTemp: 30,
+      step: 0.5,
+    });
+
+    expect(screen.getByRole('slider')).toHaveAttribute('aria-valuenow', '71.6');
+    expect(screen.getByText('69.8°F')).toBeInTheDocument();
+    expect(screen.queryByText('21°C')).not.toBeInTheDocument();
+
+    fireEvent.click(screen.getByLabelText('Increase temperature'));
+
+    expect(props.onTargetTempCommit).toHaveBeenCalledWith(expect.closeTo(22.5));
+  });
+});