Skip to content

support for d-link e-520 and more from https://github.com/bb-qq/r8152#5

Open
nikitosiusis wants to merge 1 commit into
awesometic:masterfrom
nikitosiusis:master
Open

support for d-link e-520 and more from https://github.com/bb-qq/r8152#5
nikitosiusis wants to merge 1 commit into
awesometic:masterfrom
nikitosiusis:master

Conversation

@nikitosiusis

Copy link
Copy Markdown

Good day
I suggest using r8152 driver from synology, because it additionally supports more chips, like d-link e-520

@awesometic

Copy link
Copy Markdown
Owner

Hello,

Thanks for your contribution :)
It'd be nice if it supports more devices. But how can we test if it is working? Do you have Synology?
I mean, if it doesn't have any side effects and all the additional codes working fine, I will apply this patch after every update from Realtek.

@nikitosiusis

Copy link
Copy Markdown
Author

I don't have a synology, but I have a d-link e-520(it uses 2.5g rtl8156) .
Driver from your repo didn't support it out of the box
With driver from bb-rq it started to work.
I just replaced the driver in your repo with their driver, to get dkms support. Sadly I cannot test any other adapters :)

@awesometic

Copy link
Copy Markdown
Owner

Ah okay,

Then how about making a commit only for supporting the other devices?

Seems this change has other things like: bb-qq/r8152@1f24cbb

If you want, you can make a new patch by overwriting this commit using --amend.
Or, I can make a new one, and maybe you can help me for the test :)

@nikitosiusis

nikitosiusis commented Nov 8, 2022

Copy link
Copy Markdown
Author

Yes, I think we need to amend this commit, because it is not mine actually, but I have no idea how to do it properly:)
I just used your repo for dkms module for my d-link e-520 on my laptop. It didn't work, so I got a driver from another repo. Now it works.
As far as I understand, other commits to the driver in their repo only affect building on old platforms(kernels?), I believe old platforms don't use dkms :)
I can help you with testing, but the only adapter I have is that d-link e-520.
I also use your repo for r8125 and it works great.

@awesometic

Copy link
Copy Markdown
Owner

Thank you :) I am glad to hear that my r8125-dkms also works great for you.

Then, I will look into the changes to apply only supporting the additional devices.
Except supporting old devices.

And I hope you can test my new upcoming builds. :)

@phaenomenon

Copy link
Copy Markdown

This repository seems to be no longer actively maintained, but I've continued to update and improve upon the project in my own repository. If you're looking for recent fixes and updates, feel free to check it out here:

https://github.com/phaenomenon/realtek-r8152-dkms

A huge thanks to the original author @awesometic for starting this project!

@ristomatti

Copy link
Copy Markdown

@phaenomenon Now it appears your fork is no longer actively maintained. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants