Skip to content

fix: secrets handled without environment-variables#453

Open
viviengaetan wants to merge 1 commit intoaws-actions:masterfrom
viviengaetan:fix/secrets_wrong_nesting
Open

fix: secrets handled without environment-variables#453
viviengaetan wants to merge 1 commit intoaws-actions:masterfrom
viviengaetan:fix/secrets_wrong_nesting

Conversation

@viviengaetan
Copy link

*Issue #347

Description of changes:

This PR fixes a bug where secrets were not being rendered in the generated task definition if the environment-variables input was empty or missing.

  • Added Regression Test
  • Decoupled the logic

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant