feat: support linux-arm64 package for native installer#115
feat: support linux-arm64 package for native installer#115roger-zhangg merged 10 commits intoaws-actions:mainfrom
Conversation
|
Sorry for the direct mentions but i see no other channel to get reviews for this PR, seeing the other PRs unnoticed for many months. I've found your handles as last active approvers on this repo. |
|
Thank you for your contribution! The changes look solid, but I don't quite understand why the version limit is >=1.104. Would you mind explaining to me what you mean by 'the first version for which this particular package was published'? |
|
@reedham-aws sure thing the release workflow started to generate those since 1.104.0 included, so the action would fail on older sam versions, this way the user gets at least some info why |
valerena
left a comment
There was a problem hiding this comment.
Thanks a lot for the contribution! I added a couple of small comments, and one supporting a previous comment from @reedham-aws . Ideally we don't duplicate the entire suite of tests for a single change in the middle.
roger-zhangg
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution!
Which issue(s) does this change fix?
#109
Description
adding support for native installer to work with linux arm64 packages.
added version limit for arm to >=1.104.0 as that's the first version for which this particular package was published
Checklist
npm run allBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 License.