Skip to content

fix(auth): Update exception handling for devices that don't support passkeys #3044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
If CredentialManager tells us a device doesn't support passkeys then throw a WebAuthnNotSupportedException instead of general WebAuthnException.
Added unit tests.

How did you test these changes?
Unit tests
Replicate on pre-Android 28 device

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner May 5, 2025 19:41
Copy link

codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.01%. Comparing base (ed8389b) to head (c43f90b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3044      +/-   ##
==========================================
+ Coverage   41.96%   42.01%   +0.05%     
==========================================
  Files         992      992              
  Lines       31542    31546       +4     
  Branches     4645     4648       +3     
==========================================
+ Hits        13237    13255      +18     
+ Misses      16860    16830      -30     
- Partials     1445     1461      +16     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mattcreaser mattcreaser merged commit fa4e4a7 into main May 6, 2025
5 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/passkey-android-pre-13-update branch May 6, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants