Merged
Conversation
svidgen
approved these changes
Oct 15, 2025
Member
svidgen
left a comment
svidgen
left a comment
There was a problem hiding this comment.
Makes sense to me. Thanks for digging on this!
iliapolo
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
AWS SDK V3 no longer has
retryableas a property on the errors that are thrown when throttling happens. This lead to the custom retry configuration we had set up indescribeStacksnot properly activating, which caused an increase in throttling errors with customers who had large/complicated applications.Description of how you validated changes
Created a script that ran a large number (1000) of
describeStacksoperations and observed how it ran with and without the custom retry configuration set up.Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.