fix(gen2-migration): resolve bugs in codegen auth generator#14308
Merged
iliapolo merged 15 commits intoaws-amplify:gen2-migrationfrom Nov 3, 2025
Merged
fix(gen2-migration): resolve bugs in codegen auth generator#14308iliapolo merged 15 commits intoaws-amplify:gen2-migrationfrom
iliapolo merged 15 commits intoaws-amplify:gen2-migrationfrom
Conversation
.../gen2-migration/amplify-gen2-migration-codegen-dg/src/migration_head/src/command-handlers.ts
Fixed
Show fixed
Hide fixed
.../gen2-migration/amplify-gen2-migration-codegen-dg/src/migration_head/src/command-handlers.ts
Fixed
Show fixed
Hide fixed
iliapolo
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fixes bugs in the auth code generator that were causing incorrect TypeScript generation during Gen1 to Gen2 migration.
Before this fix, simple email logic was suppported. Custom email verification messages were not migrating
Before the fix, the code used runtime type inspection (typeof value === 'object') during code generation, which couldn't properly distinguish between different property types. This pr
When migrating from Gen1 to Gen2, the code tries to find Lambda function names from file paths. It expects the lambda code to follow a specific directory format and checks for the name hardcoded in that format. This is brittle and can fail easily if user decides to change their directory format for lambda functions. Therefore, this pr:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.