chore: update directory structure and file names#14311
chore: update directory structure and file names#14311kaizencc merged 3 commits intoaws-amplify:gen2-migrationfrom
Conversation
kaizencc
left a comment
There was a problem hiding this comment.
thanks! i'm still confused by these parts of the structure:
srcfolder --> why is it necessary to have anothersrcfolder? the folder structure is nowamplify-cli/src/comands/codegen-generate/src.srctypically is a top-level folder that delineates where all the source code lives so it's confusing to me to see it again.migration_headfolder -> what does this mean? why is this the head of the migration?cllfolder -> are we releasinggenerateas a CLI separate from themigratetool?npm_packagefolder -> are we releasinggenerateas a separate npm package?test_utilsfolder -> ok, but where are the tests? I can only seeauth/index.test.ts. in the structure of thegen2-migrationbranch, i seesrc/__tests__/gen2-migrationwith some tests from Sai and Sanjana. i think that's where all the unit tests belong, and if so, that's wheretest_utilsbelong too if they are truly just utilities for tests
Although codegen is not its separate package, it is currently built to have some separate config requirements than amplify-cli.
I can make a separate pr to restructure the tests when they are ready en masse. Currently its just one file |
Changes include:
The src directory needs to remain for the codegen-generate folder since there would be an additional tsconfig file added for codegen in the future. This is to enforce strict:false behavior in tsconfig as it was in the old tool. Currently, amplify-cli's tsconfig has been modified to make the option strict:false from strict:true (which needs to change back before merging to dev)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.