Skip to content

fix: use execFileSync for git commands in preInitSetup to prevent shell injection #14957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
svidgen wants to merge 1 commit into from
Closed

fix: use execFileSync for git commands in preInitSetup to prevent shell injection #14957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/amplify-cli/src/init-steps/preInitSetup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { $TSContext, AmplifyError, getPackageManager, LocalEnvInfo, pathManager } from '@aws-amplify/amplify-cli-core';
import { execSync } from 'child_process';
import { execFileSync, execSync } from 'child_process';
import * as fs from 'fs-extra';
import * as url from 'url';
import { generateLocalEnvInfoFile } from './s9-onSuccess';
Expand Down Expand Up @@ -83,7 +83,7 @@ function validateGithubRepo(repoUrl: string | boolean): asserts repoUrl is strin
}
url.parse(repoUrl);

execSync(`git ls-remote ${repoUrl}`, { stdio: 'ignore' });
execFileSync('git', ['ls-remote', repoUrl], { stdio: 'ignore' });
} catch (e) {
throw new AmplifyError(
'ProjectInitError',
Expand All @@ -110,7 +110,7 @@ const cloneRepo = async (repoUrl: string): Promise<void> => {
}

try {
execSync(`git clone ${repoUrl} .`, { stdio: 'inherit' });
execFileSync('git', ['clone', repoUrl, '.'], { stdio: 'inherit' });
} catch (e) {
throw new AmplifyError(
'ProjectInitError',
Expand Down
Loading