fix(amplify-category-storage): make IAM policy names environment-specific - #14962
Open
w3lld1 wants to merge 1 commit into
Open
fix(amplify-category-storage): make IAM policy names environment-specific#14962w3lld1 wants to merge 1 commit into
w3lld1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I made generated S3 IAM policy names environment-specific by appending the current Amplify environment name to the existing policy UUID. This prevents two environments that share imported auth roles from trying to manage identically named inline policies.
I also added a focused regression test for the generated policy names and updated the existing stack-transform expectations.
Issue #, if available
Fixes #14961
Description of how you validated changes
yarn lerna run build --scope @aws-amplify/amplify-category-storage --include-dependencies --concurrency 4node ../../node_modules/jest/bin/jest.js --runInBand --coverage=falsefrompackages/amplify-category-storage(15 suites, 48 tests)I did not run cloud E2E tests or the macOS CI job locally.
Checklist
yarn testpasses for the changed packageBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.