fix(cli): paginate API Gateway resources when resolving REST API root resource - #14967
Open
vishwakt wants to merge 1 commit into
Open
fix(cli): paginate API Gateway resources when resolving REST API root resource#14967vishwakt wants to merge 1 commit into
vishwakt wants to merge 1 commit into
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
fetchRestApiRootResourceIdcalled API GatewayGetResourcesonce and never followed the pagination token. API Gateway returns 25 resources per page by default with no ordering guarantee, so on REST APIs with more than 25 resources the root/resource can land on a later page andgen2-migration generateorassessfails with "Root resource not found for REST API" even though the API is healthy.This change uses
paginateGetResourcesto walk pages until the root resource is found, returning early once it is. This matches the paginator pattern already used inaws-fetcher.tsfor CloudFormation and Cognito calls.Issue #, if available
Fixes #14948
Description of how you validated changes
Added unit tests for
fetchRestApiRootResourceIdcovering:RestApiResourceNotFoundErroris thrownAll existing
gen2-migrationREST API generator and infra tests pass.Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.