chore(dev): Upgraded upload-artifact to v4.6.0#5895
Merged
Conversation
ekjotmultani
previously approved these changes
Feb 4, 2025
tyllark
changed the title
tyllark
force-pushed
the
chore/update-upload-artifact
branch
from
aad00f3 to
b650a32
Compare
ekjotmultani
approved these changes
Feb 10, 2025
tyllark
added a commit
that referenced
this pull request
Mar 6, 2025
* chore(dev): Upgraded upload-artifact ot v4.6.0 * chore(): update constraints for webview_flutter_wkwebview * chore(): forked a repo and updated references * chore(): Updated Android SDK version to 35 * chore(): added updated GitHub action Android emulator location
tyllark
added a commit
that referenced
this pull request
Mar 7, 2025
* chore(dev): Upgraded upload-artifact ot v4.6.0 * chore(): update constraints for webview_flutter_wkwebview * chore(): forked a repo and updated references * chore(): Updated Android SDK version to 35 * chore(): added updated GitHub action Android emulator location
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Upload Artifact v3 has been deprecated which is causing our Github Actions to fail. This change upgrades Upload Artifact to v4.
webview_flutter_wkwebview released a breaking change in patch in version 3.18.0. Added a version cap to avoid this conflict in one of our example projects.
created a fork of a repo here and updated our references to point to it. We will need to create a long term solution for this, but this will protect us in the meantime.
Updated Android API test version from 34 to 35 so we are testing on the latest version.
Android emulators are being generated in a different location than expected while running Github Actions. Updated our Android emulator path to be
$HOME/.config/.android/avd(previously$HOME/.android/avd) to prevent this issue.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.