Closed
Conversation
ekjotmultani
changed the base branch from
main
to
feat/amplify-foundation-dart-minimal
ekjotmultani
force-pushed
the
feat/kinesis-e2e-infra
branch
from
0a451d4 to
a04df03
Compare
Adds the foundational package with minimal constructs needed for the Kinesis client libraries: - AmplifyException base class - AWSCredentialsProvider<T> and AWSCredentials sealed hierarchy - Logger interface with AmplifyLogger implementation - LogLevel enum - Result<T, E> sealed type
Provides V2CredentialsProviderBridge to bridge aws_common (V2) credentials to amplify_foundation_dart (V3) credentials. Shared by kinesis client packages to avoid duplicating bridge logic.
…plify backend Provisions Kinesis Data Stream, Firehose delivery stream, IAM user, and Secrets Manager secret via an Amplify Gen 2 backend using backend.createStack() to access CDK directly — no auth or other Amplify categories needed. Removes the standalone KinesisTestStack and KinesisTestResources construct from infra/, along with references in the main integ stack and GitHub stack.
- Revert unrelated whitespace changes to infra/lib/stack.ts and infra/lib/github/github.ts - Replace manual pubspec_overrides.yaml with aft bootstrap - Update workflow to match repo conventions (action versions, submodule init, log_cw_metric_wrapper, timeout, defaults) - Remove IAM user, access key, and Secrets Manager secret from backend.ts (credentials managed outside stack)
…lid category list in log_cw_metric so that\nthe kinesis package working directory is recognized by the CI\nmetric logging step."
…e same pattern as Analytics/Pinpoint and the Android KDS\nlibrary: include auth (Cognito) in the backend and grant the\nauthenticated IAM role permissions to Kinesis/Firehose resources.\n\nThis replaces the custom Secrets Manager credential injection with\nthe standard fetch_backends workflow pattern, making E2E tests use\nCognito-authenticated credentials like real customers would.\n\n- Add auth resource with pre-sign-up auto-confirm trigger\n- Grant authenticatedUserIamRole Kinesis and Firehose permissions\n- Rewrite E2E workflow to use fetch_backends composite action\n- Remove custom KINESIS_E2E secret fetching from workflow"
ekjotmultani
force-pushed
the
feat/kinesis-e2e-infra
branch
from
a04df03 to
18f1e9f
Compare
…ory.kinesis so deploy_gen2.dart can deploy the kinesis\nbackend and upload amplify_outputs.dart to S3. The kinesis backend\nshares its config with both aws_kinesis_datastreams and\naws_amazon_firehose packages via sharedOutputs."
jvh-aws
reviewed
Mar 6, 2026
| enforceSSL: true, | ||
| }); | ||
|
|
||
| // --- IAM role for Firehose → S3 --- |
Contributor
There was a problem hiding this comment.
I think this is unrelated to Kinesis. Can we handle this separately and remove from this PR?
Renames gen2 S3 buckets from `<category>-gen2-integ-<uuid>` to `amplify-<category>-test-<uuid>` so they match the existing IAM policy glob on the GitHub OIDC role without requiring a CDK deploy.
The dart_test.yaml skips e2e-tagged tests by default for local dev. CI needs --run-skipped to override this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.