Draft
Conversation
cadivus
force-pushed
the
feat/analyzer/license-header-in-dart-files
branch
from
44c041b to
fa3149f
Compare
This reverts commit 9b9a390.
These packages from dart-lang/site-shared were removed upstream in June 2024 (commit d79a7a2). They depend on build ^2.4.0 which caps analyzer <8.0.0, conflicting with amplify_lints which now requires analyzer ^9.0.0 for the analysis_server_plugin-based lint rule. The upstream replacement (pkgs/excerpter) no longer uses the build package at all, removing the analyzer version conflict.
…lyzer range - Bump amplify_lints to custom_lint_builder ^0.8.0 (analyzer ^8.0.0) instead of ^0.7.0 (analyzer ^7.0.0), enabling compatibility with packages that need newer analyzer versions. - Widen worker_bee_builder's analyzer constraint from ^9.0.0 to >=8.0.0 <11.0.0 to match build ^4.0.0's range, allowing the solver to find a common analyzer version (8.x) that satisfies both custom_lint_builder and worker_bee_builder.
custom_lint merges workspace deps and cannot reconcile version constraints (from parent packages) with path deps (from examples). Use version constraints in example pubspec.yaml files matching the parent pattern. The pubspec_overrides.yaml files (generated by aft) already provide path overrides for local development, so the local repo version is still used during development.
This reverts commit 1395230.
Use 'any' constraints for analyzer, analysis_server_plugin, and analyzer_plugin in amplify_lints. The analysis server loads plugins in its own context, so these deps don't need tight constraints. Using 'any' prevents version conflicts in consuming packages that may need different analyzer versions (e.g. worker_bee_builder needs ^9.0.0 while test ecosystem needs <8.0.0). Also restores the analysis_server_plugin-based lint implementation with proper plugin registration, quick fixes, and the native analyzer plugin YAML config (analyzer: plugins: amplify_lints:).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to make sure the license headers are set as we need it.