fix(authenticator): Add accessible names for password toggle and form errors - #7254
Open
VarshithaPamisetty wants to merge 8 commits into
Open
fix(authenticator): Add accessible names for password toggle and form errors#7254VarshithaPamisetty wants to merge 8 commits into
VarshithaPamisetty wants to merge 8 commits into
Conversation
… errors Adds tooltip/accessible names to the password visibility toggle so screen readers announce "Show password"/"Hide password", and wraps banner and form content in semantics so validation errors are announced. Tooltip strings are defined in the inputs ARB source (inputs_en.arb) and reflected in the generated localizations. Continues the work in #6577 by @ekjotmultani. Issues: #6568 #6581
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7254 +/- ##
==========================================
+ Coverage 40.97% 41.24% +0.26%
==========================================
Files 121 121
Lines 8273 8288 +15
Branches 3598 3604 +6
==========================================
+ Hits 3390 3418 +28
+ Misses 4883 4870 -13 🚀 New features to boost your workflow:
|
cadivus
reviewed
Aug 10, 2026
cadivus
left a comment
cadivus
left a comment
Member
There was a problem hiding this comment.
Where does this new gap between "Password" and "Confirm Password" come from? I think it looks a bit odd.
Member
Is it eventually caused by the empty helper text? If so, how about setting https://api.flutter.dev/flutter/material/InputDecoration/helperStyle.html to make the font small (1? even 0?). |
Contributor
Author
|
Yes, it's from the "helperText: ' '" workaround. I'll try your helperStyle suggestion to collapse the gap and confirm VoiceOver still announces the error, then update. |
…sert semantic labels The helperText:' ' workaround for flutter#99715 (validation errors not announced on web) is no longer needed: the bug was fixed in 2023 and the package's minimum Flutter is 3.41.0. Verified on 3.41.0 that field errors are still announced without it. Removing it also fixes the extra vertical gap under every field and reverts the golden snapshots to main. Strengthens the a11y test to assert the toggle's semantic label via tester.getSemantics + isSemantics.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #6568
Fixes #6581
Description:
Continues the work in #6577 by @ekjotmultani, addressing the review feedback.
Adds tooltip/accessible names to the password visibility toggle so screen readers announce "Show password"/"Hide password" (#6568), and wraps banner and form content in semantics so validation errors are announced (#6581).
Review follow-ups from #6577:
helperTextis set on the input fields as a workaround for [a11y] VoiceOver does not announce form validation errors flutter/flutter#99715 so validation errors are announced on web; this adds a consistent helper line under every field, which the updated golden snapshots reflect.Tests
dart analyzeanddart formatclean.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.