fix(authenticator): Make Verify User Skip button visible in dark mode - #7275
Draft
VarshithaPamisetty wants to merge 2 commits into
Draft
fix(authenticator): Make Verify User Skip button visible in dark mode#7275VarshithaPamisetty wants to merge 2 commits into
VarshithaPamisetty wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7275 +/- ##
==========================================
- Coverage 40.97% 40.97% -0.01%
==========================================
Files 121 121
Lines 8273 8271 -2
Branches 3598 3598
==========================================
- Hits 3390 3389 -1
+ Misses 4883 4882 -1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #5984
Description:
The Verify User "Skip" button hardcoded its text color to
Theme.of(context).primaryColor, which is invisible in dark mode. Removing it lets the button inherit theTextButtondefault (colorScheme.primary), so it stays visible in both themes. Supersedes #6001 by @ekjotmultani.Screenshots
Tests
verifyUsergoldens;dart analyzeanddart formatclean.