fix(ci): Fix flaky Android e2e (adb detection + per-attempt timeout) - #7281
Draft
VarshithaPamisetty wants to merge 9 commits into
Draft
fix(ci): Fix flaky Android e2e (adb detection + per-attempt timeout)#7281VarshithaPamisetty wants to merge 9 commits into
VarshithaPamisetty wants to merge 9 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7281 +/- ##
=======================================
Coverage 40.98% 40.98%
=======================================
Files 121 121
Lines 8273 8273
Branches 3598 3598
=======================================
Hits 3391 3391
Misses 4882 4882 🚀 New features to boost your workflow:
|
…e test The 'should LIST blogs with Model helper with query predicate' test created a blog then immediately listed it with a filter, but AppSync list (DynamoDB Scan) is eventually consistent, so the new item was intermittently not yet visible (Expected 1, Actual 0). Add a queryModelUntil helper that re-runs the list query until the expected result appears or a timeout elapses.
Revert the poll helper (root cause is not timing) and log filtered vs unfiltered blog list to determine why the filtered query returns empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the flaky Android e2e in two parts:
5554and restart the adb server between boot checks, so the emulator reliably registers (fixesdevice 'emulator-5554' not found).Tests
Ran the full Android e2e (24 and 35); the emulator registers reliably and the auth suite completes within the raised timeout.