fix: For bug when cookies are disabled using window side-effects - #10846
Closed
stocaaro wants to merge 2 commits into
Closed
fix: For bug when cookies are disabled using window side-effects#10846stocaaro wants to merge 2 commits into
stocaaro wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
As an alternative to pulling in and fixing the paho-mqtt vendor library, this uses side-effects to catch the localStorage error, which it then replaces after Paho has loaded.
The replacement is shallow and this may very well result in unexpected side-effects in other libraries behavior.
Issue #, if available
Description of how you validated changes
Tested by:
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.