Open
Conversation
bobbor
requested review from
a team,
Amplifiyer,
avi-karthik,
pranavosu and
sobolk
as code owners
bobbor
force-pushed
the
feature/12820/crossTab-signIn-signOut
branch
from
de72c25 to
1b8a803
Compare
bobbor
force-pushed
the
feature/12820/crossTab-signIn-signOut
branch
2 times, most recently
from
c82b5ab to
e9c1725
Compare
bobbor
force-pushed
the
feature/12820/crossTab-signIn-signOut
branch
from
896595b to
ccfd497
Compare
bobbor
force-pushed
the
feature/12820/crossTab-signIn-signOut
branch
from
ccfd497 to
6bd538e
Compare
| }); | ||
|
|
||
| describe('setupNotify', () => { | ||
| it('should setup a KeyValueStorageEvent listener', async () => { |
Member
There was a problem hiding this comment.
Can we split this into multiple tests? It will make debugging easier in case of failures
|
|
||
| it('should not allow crossTab dispatch in other channels', () => { | ||
| Hub.dispatch( | ||
| // this looks weird but is only used to mute TS. |
ahmedhamouda78
approved these changes
Oct 16, 2025
Member
ahmedhamouda78
left a comment
ahmedhamouda78
left a comment
There was a problem hiding this comment.
Just one minor comment on one of the tests. Other than that, looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Introduce the possibility of listening to crossTab auth events.
The changes introduce a listener for storage events on the DefaultStorage (
window.localStorage) as well as on the SessionStorage (window.sessionStorage)since the logic for adding and removing listeners is on the
KeyValueStorageit is (theoretically) possible in future to add listeners for crossTab events on CookieStorage and CustomStorage.since it listens to all storage events, it then filters the event based on token-naming convention to dispatch crossTab Hub events on the "auth" channel.
the typing and implementation of
dispatchandlistenon the hub makes sure, that only auth-channel events are allowed for crossTab communication.Issue #, if available
Issue 12820
Description of how you validated changes
I added unit-tests and did manual explorative testing.
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.