feat(cloudwatch): add CloudWatch client - #4219
Open
thisisabhash wants to merge 8 commits into
Open
Conversation
thisisabhash
had a problem deploying
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Failure
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
temporarily deployed
to
IntegrationTest
May 8, 2026 23:50 — with
GitHub Actions
Inactive
thisisabhash
marked this pull request as draft
May 8, 2026 23:50
thisisabhash
marked this pull request as ready for review
August 10, 2026 17:29
* feat(logging): add v3 cloudwatch @SPI definitions * add privacyinfo
* feat(logging): add v3 cloudwatch @SPI definitions * add privacyinfo * chore(logging): move shared code to internal module * fix unit tests --------- Co-authored-by: Harsh <6162866+harsh62@users.noreply.github.com>
* feat(logging): add v3 cloudwatch @SPI definitions * add privacyinfo * chore(logging): move shared code to internal module * fix unit tests * feat(logging): add implementation for cloudwatch client --------- Co-authored-by: Harsh <6162866+harsh62@users.noreply.github.com>
* feat(logging): add v3 cloudwatch @SPI definitions * add privacyinfo * chore(logging): move shared code to internal module * fix unit tests * feat(logging): add implementation for cloudwatch client * chore(logging): add unit tests for cloudwatch client --------- Co-authored-by: Harsh <6162866+harsh62@users.noreply.github.com>
…ild warnings (#4215) * feat(logging): add v3 cloudwatch @SPI definitions * add privacyinfo * chore(logging): move shared code to internal module * fix unit tests * feat(logging): add implementation for cloudwatch client * chore(logging): add unit tests for cloudwatch client * chore(logging): refactor code to use shared sdk client * update code * chore(logging): add integration tests for cloudwatch client (#4216)
* chore(logging): use unique identifier per client for log streams and local storage path * enable unit tests in ci/cd * revert storage path identifier changes * fix swiftformat issues * enable flaky test and add doc comments * update Package.resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #
NA
Description
What Changed
New:
AmplifyCloudWatchLoggingClientAmplifyFoundation.LogSinkBehaviorCloudWatchLogsClientinstance (created once ininit)storagePathIdentifier(prevents collisions between multiple client instances)eventspublisher for observing flush/write failures@_spi(AmplifyExperimental)public API surfaceNew:
InternalCloudWatchLoggingshared moduleLogFile,LogRotation,LogActor(persistence)LogBatch,LogBatchConsumer,LogBatchProducer,LogEntryRepresentable(protocols)LoggingNetworkMonitor(network connectivity)CloudWatchConstants(SDK limits)packageaccess levelModified:
AWSCloudWatchLoggingPluginInternalCloudWatchLoggingfor shared persistence and networking typesAWSCloudWatchLoggingMonitorDelegatepublic APITests
AmplifyCloudWatchLoggingClientto CI unit test workflowPackage.swift
InternalCloudWatchLogging,AmplifyCloudWatchLoggingClient(updated),AmplifyCloudWatchLoggingClientTestsAmplifyCloudWatchLoggingClientAWSCloudWatchLoggingPluginandAWSCloudWatchLoggingPluginTestsTesting
swift test --filter AmplifyCloudWatchLoggingClientTests— 50+ tests, all passswift test --filter AWSCloudWatchLoggingPluginTests— 60 tests, 59 pass (1 pre-existing flaky timeout)Directory Structure
General Checklist
Given When Theninline code documentation and are named accordinglytestThing_condition_expectation()By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.