chore(auth): fix web authn and push notifications integration tests - #4241
Merged
Conversation
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
had a problem deploying
to
IntegrationTest
June 30, 2026 17:48 — with
GitHub Actions
Error
thisisabhash
force-pushed
the
chore/fix-auth-integ-tests
branch
from
June 30, 2026 17:58
4c0bace to
32db683
Compare
thisisabhash
temporarily deployed
to
IntegrationTest
June 30, 2026 17:58 — with
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4241 +/- ##
==========================================
- Coverage 66.95% 66.74% -0.21%
==========================================
Files 1151 1151
Lines 43869 43869
==========================================
- Hits 29372 29280 -92
- Misses 14497 14589 +92
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
harsh62
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #
Failing WebAuthN and Push Notification Integration tests
Description
Fixes three failing integration tests on CI caused by the Xcode 26.3 / watchOS 26.2 upgrade and the aws-sdk-swift 1.7.27 bump.
Changes
1. AuthWebAuthnApp — fix flaky system dialog detection
The test previously checked for an API error (1s timeout) and the system Continue button (6s timeout) as two separate sequential steps. If the Cognito
startWebAuthnRegistrationcall was slow or transiently failed after the 1s window, the test would proceed to wait for a button that would never appear.Restructured to wait for the
ASAuthorizationControllerContinueButtondirectly inside theattemptretry loop (30s per attempt, up to 3 retries). This handles both slow network responses and transient API failures in a single pass.2. PushNotificationsWatchApp / AnalyticsWatchApp — fix simulator installation on watchOS 26.2
Both standalone watch app targets had
SKIP_INSTALL = YES. In Xcode 26.3, this preventsWKWatchOnlyapps from being installed on the watchOS 26.2 simulator, causingFBSApplicationLibraryto return nil when the test runner attempts to launch them. Changed toSKIP_INSTALL = NO.Files changed
AmplifyPlugins/Auth/Tests/AuthWebAuthnApp/AuthWebAuthnAppUITests/AuthWebAuthnAppUITests.swiftAmplifyPlugins/Analytics/Tests/AnalyticsHostApp/AnalyticsHostApp.xcodeproj/project.pbxprojAmplifyPlugins/Notifications/Push/Tests/PushNotificationHostApp/PushNotificationHostApp.xcodeproj/project.pbxprojTest plan
AuthWebAuthnAppUI test passes on iOS 18.5 (Xcode 16.4)PushNotificationWatchTestspasses on watchOS 26.2 (Xcode 26.3)AnalyticsWatchApptests pass on watchOS 26.2 (Xcode 26.3)Test plan
AuthWebAuthnAppintegration test passes on iOS 18.5 (Xcode 16.4)PushNotificationWatchTestsintegration test passes on watchOS 26.2 (Xcode 26.3)General Checklist
Given When Theninline code documentation and are named accordinglytestThing_condition_expectation()By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.