-
Notifications
You must be signed in to change notification settings - Fork 236
feat: add connect client #4245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: add connect client #4245
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8560149
feat: add connect client
thisisabhash bc45b57
add unit tests to ci/cd
thisisabhash 23e02d4
fix unit tests
thisisabhash ecccf0f
update amplify outputs configuration parsing
thisisabhash 7ed79ee
address review comments
thisisabhash 6fa121b
feat(connect): rework client to Option C API contract
ekjotmultani afac374
chore(connect): declare UserDefaults required-reason API in privacy m…
ekjotmultani 0ce0c50
fix(connect): declare collected data types in privacy manifest
ekjotmultani 214dd6e
fix(connect): enforce https endpoints and validate input lengths
ekjotmultani 9af6b08
fix(connect): count validation lengths in UTF-16 code units to match …
ekjotmultani c2a85dc
address review comments
thisisabhash 1e81b7a
update files
thisisabhash 4b33712
fix swiftformat issue
thisisabhash 843f66a
fix removeDevice api
thisisabhash File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| name: Unit Tests | Connect | ||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| ios: | ||
| description: '📱 iOS' | ||
| required: true | ||
| default: true | ||
| type: boolean | ||
| macos: | ||
| description: '💻 macOS' | ||
| required: true | ||
| default: true | ||
| type: boolean | ||
| tvos: | ||
| description: '📺 tvOS' | ||
| required: true | ||
| default: true | ||
| type: boolean | ||
| watchos: | ||
| description: '⌚️ watchOS' | ||
| required: true | ||
| default: true | ||
| type: boolean | ||
| visionos: | ||
| description: 'ᯅ visionOS' | ||
| required: true | ||
| default: true | ||
| type: boolean | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| connect-unit-tests: | ||
| uses: ./.github/workflows/run_unit_tests_platforms.yml | ||
| with: | ||
| scheme: AmplifyConnectClient |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 changes: 89 additions & 0 deletions
89
.swiftpm/xcode/xcshareddata/xcschemes/AmplifyConnectClient.xcscheme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <Scheme | ||
| LastUpgradeVersion = "2600" | ||
| version = "1.3"> | ||
| <BuildAction | ||
| parallelizeBuildables = "YES" | ||
| buildImplicitDependencies = "YES" | ||
| buildArchitectures = "Automatic"> | ||
| <BuildActionEntries> | ||
| <BuildActionEntry | ||
| buildForTesting = "YES" | ||
| buildForRunning = "YES" | ||
| buildForProfiling = "YES" | ||
| buildForArchiving = "YES" | ||
| buildForAnalyzing = "YES"> | ||
| <BuildableReference | ||
| BuildableIdentifier = "primary" | ||
| BlueprintIdentifier = "AmplifyConnectClient" | ||
| BuildableName = "AmplifyConnectClient" | ||
| BlueprintName = "AmplifyConnectClient" | ||
| ReferencedContainer = "container:"> | ||
| </BuildableReference> | ||
| </BuildActionEntry> | ||
| </BuildActionEntries> | ||
| </BuildAction> | ||
| <TestAction | ||
| buildConfiguration = "Debug" | ||
| selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB" | ||
| selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB" | ||
| shouldUseLaunchSchemeArgsEnv = "YES" | ||
| codeCoverageEnabled = "YES" | ||
| onlyGenerateCoverageForSpecifiedTargets = "YES"> | ||
| <CodeCoverageTargets> | ||
| <BuildableReference | ||
| BuildableIdentifier = "primary" | ||
| BlueprintIdentifier = "AmplifyConnectClient" | ||
| BuildableName = "AmplifyConnectClient" | ||
| BlueprintName = "AmplifyConnectClient" | ||
| ReferencedContainer = "container:"> | ||
| </BuildableReference> | ||
| </CodeCoverageTargets> | ||
| <Testables> | ||
| <TestableReference | ||
| skipped = "NO"> | ||
| <BuildableReference | ||
| BuildableIdentifier = "primary" | ||
| BlueprintIdentifier = "AmplifyConnectClientTests" | ||
| BuildableName = "AmplifyConnectClientTests" | ||
| BlueprintName = "AmplifyConnectClientTests" | ||
| ReferencedContainer = "container:"> | ||
| </BuildableReference> | ||
| </TestableReference> | ||
| </Testables> | ||
| </TestAction> | ||
| <LaunchAction | ||
| buildConfiguration = "Debug" | ||
| selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB" | ||
| selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB" | ||
| launchStyle = "0" | ||
| useCustomWorkingDirectory = "NO" | ||
| ignoresPersistentStateOnLaunch = "NO" | ||
| debugDocumentVersioning = "YES" | ||
| debugServiceExtension = "internal" | ||
| allowLocationSimulation = "YES"> | ||
| </LaunchAction> | ||
| <ProfileAction | ||
| buildConfiguration = "Release" | ||
| shouldUseLaunchSchemeArgsEnv = "YES" | ||
| savedToolIdentifier = "" | ||
| useCustomWorkingDirectory = "NO" | ||
| debugDocumentVersioning = "YES"> | ||
| <MacroExpansion> | ||
| <BuildableReference | ||
| BuildableIdentifier = "primary" | ||
| BlueprintIdentifier = "AmplifyConnectClient" | ||
| BuildableName = "AmplifyConnectClient" | ||
| BlueprintName = "AmplifyConnectClient" | ||
| ReferencedContainer = "container:"> | ||
| </BuildableReference> | ||
| </MacroExpansion> | ||
| </ProfileAction> | ||
| <AnalyzeAction | ||
| buildConfiguration = "Debug"> | ||
| </AnalyzeAction> | ||
| <ArchiveAction | ||
| buildConfiguration = "Release" | ||
| revealArchiveInOrganizer = "YES"> | ||
| </ArchiveAction> | ||
| </Scheme> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fields below describe an Amazon Pinpoint backend and are optional because
notificationsmay be present without Pinpoint being configured — for examplewhen only Amazon Connect is provisioned, the backend emits
notificationscontaining just an
amazon_connectblock (there's no pinpoint block). Declaring these as non-optional madeAmplify.configure()fail to decode such a configuration outright,preventing an app from using any category. Consumers must therefore check
for the values they need; see
AWSPinpointPushNotificationsPlugin+Configure.