Skip to content

feat: add French (fr) localization - #227

Open
c0detamer wants to merge 1 commit into
aws-amplify:mainfrom
c0detamer:feat/french-localization
Open

feat: add French (fr) localization#227
c0detamer wants to merge 1 commit into
aws-amplify:mainfrom
c0detamer:feat/french-localization

Conversation

@c0detamer

@c0detamer c0detamer commented Apr 27, 2026

Copy link
Copy Markdown

Description

Adds French localization support to the FaceLiveness package. French-speaking users will see all liveness check UI strings in French automatically when their device language is set to French — no changes required from app developers.

Changes

  • Added Sources/FaceLiveness/Resources/fr.lproj/Localizable.strings with French translations for all 38 UI strings
  • Updated Package.swift to declare fr.lproj as a processed resource so SPM bundles it at build time

How it works

The existing NSLocalizedString/Bundle.module lookup in String+Localizable.swift already handles locale selection automatically. iOS falls back to Base.lproj (English) for any non-French locale or missing key — no Swift source changes were needed.

Testing

  • swift package dump-package confirms fr.lproj is correctly declared with the process rule alongside Base.lproj
  • All 38 keys in fr.lproj match exactly the keys in Base.lproj — no missing or extra keys
  • Existing English behavior is unaffected; Base.lproj/Localizable.strings is unchanged

Checklist

  • French translations cover all existing localization keys
  • Base.lproj/Localizable.strings is unmodified
  • Package.swift builds without errors
  • Tested on a French-locale device/simulator

@c0detamer
c0detamer requested review from a team as code owners April 27, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant