Skip to content

Conversation

@reesscot
Copy link
Contributor

@reesscot reesscot commented Aug 2, 2023

Description of changes

Adds Expo Snack for SignUp Attributes showing all available attributes.

image

Issue #, if available

Fixes #4309

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • Relevant documentation is changed or added (and PR referenced)
  • yarn test passes and tests are updated/added
  • No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@reesscot reesscot requested a review from a team as a code owner August 2, 2023 19:10
@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2023

⚠️ No Changeset found

Latest commit: 1a820f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment on lines +20 to +38
signUpAttributes={[
'address',
'birthdate',
'email',
'family_name',
'gender',
'given_name',
'locale',
'middle_name',
'name',
'nickname',
'phone_number',
'picture',
'preferred_username',
'profile',
'updated_at',
'website',
'zoneinfo',
]}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need an example for this? Feel like a list of attributes/link to the OIDC spec should be sufficient?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, I thought I was missing something. Will update docs to just list these

@reesscot reesscot temporarily deployed to ci August 2, 2023 19:25 — with GitHub Actions Inactive
@reesscot reesscot temporarily deployed to ci August 2, 2023 19:25 — with GitHub Actions Inactive
@reesscot reesscot temporarily deployed to ci August 2, 2023 19:25 — with GitHub Actions Inactive
@reesscot reesscot temporarily deployed to ci August 2, 2023 19:25 — with GitHub Actions Inactive
@reesscot reesscot closed this Aug 10, 2023
@reesscot reesscot deleted the reesscot-rn-add-all-attributes branch November 2, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FR (Docs): Missing Expo Snack for RN Authenticator "All Attributes"

2 participants