Skip to content

docs: StorageManager prop corrections #5543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: StorageManager prop corrections #5543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ You should open an issue to discuss your pull request, unless it's a trivial cha

1. Fork & Clone this repo (Make sure to disable associated GitHub Actions. In fork go to Settings > Actions > General > Disable actions > save)
1. [`nvm install`](https://github.com/nvm-sh/nvm)
1. [`nvm use`](https://github.com/nvm-sh/nvm)
1. `yarn setup`
1. [`nvm use`](https://github.com/nvm-sh/nvm) (uses `.nvmrc` to use supported Node version)
1. `yarn setup` (note: this includes `yarn install`)
1. Within your fork, create a new branch based on the issue you're addressing, e.g. `git checkout -b angular/remove-browser-module`
1. Commit your code using [conventional commit messages](https://www.conventionalcommits.org/en/v1.0.0/#summary), e.g. `git commit -m "chore: remove browser module"`.
1. Once your work is committed, validate your changes according to [local development guides](#local-development-guides).
Expand Down
2 changes: 1 addition & 1 deletion docs/src/pages/[platform]/connected-components/storage/storagemanager/props.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export const STORAGE_MANAGER = [
name: `processFile?`,
description:
'Called immediately before uploading a file to allow you to edit the key or the file itself. The function can return synchronously or return a promise.',
type: `(params: {key: string, file: Blob}) => Promise<{key: string, file: Blob} & Record<string, any>> | {key: string, file: Blob} & Record<string, string>;`,
type: `(params: {key: string, file: File}) => Promise<{key: string, file: File} & Record<string, any>> | {key: string, file: File} & Record<string, string>;`,
},
{
name: `defaultFiles?`,
Expand Down