Skip to content

chore: Migrated Vite to Rollup, Removed Vite related dependencies #6423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

chore: Migrated Vite to Rollup, Removed Vite related dependencies #6423

wants to merge 19 commits into from

Conversation

yuhengshs
Copy link
Contributor

@yuhengshs yuhengshs commented Mar 12, 2025 •
edited
Loading

Description of changes

This PR serves the purpose of migrating from Vite to Rollup in vue package

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yuhengshs yuhengshs requested a review from a team as a code owner March 12, 2025 16:25
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1558a50

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

calebpollman
calebpollman reviewed Mar 12, 2025
View reviewed changes
Copy link
Member

@calebpollman calebpollman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this @yuhengshs! Have some questions on the configuration changes and there's some cleanup that can be addressed before merging. Curious how we are validating the compatibility of the new build artifacts against the existing artifacts?

@yuhengshs yuhengshs force-pushed the chore/migrate-vite-to-rollup branch 3 times, most recently from 07413ea to 3763460 Compare March 18, 2025 23:15
@yuhengshs yuhengshs force-pushed the chore/migrate-vite-to-rollup branch from 3763460 to 029097a Compare March 18, 2025 23:31
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 28, 2025
View reviewed changes
@yuhengshs yuhengshs force-pushed the chore/migrate-vite-to-rollup branch from a26b6c8 to c23fceb Compare March 28, 2025 22:28
@yuhengshs yuhengshs force-pushed the chore/migrate-vite-to-rollup branch from c23fceb to d4e5d95 Compare March 28, 2025 22:49
@yuhengshs yuhengshs marked this pull request as ready for review March 29, 2025 06:25
calebpollman
calebpollman reviewed May 1, 2025
View reviewed changes
Copy link
Member

@calebpollman calebpollman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Called out some concerns in the comments and left some general questions/feedback

examples/vue/src/main.ts
Comment on lines +4 to +11
import AmplifyUIVue from '@aws-amplify/ui-vue';
import '@aws-amplify/ui-vue/styles.css';

createApp(App).use(router).mount('#app');
// Create app and register plugins
const app = createApp(App);
app.use(router);
app.use(AmplifyUIVue);
app.mount('#app');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these changes equate to the build artifacts having a breaking change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebpollman calebpollman calebpollman left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuhengshs @calebpollman