Skip to content

fix translation key mismatch #6482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wapa5pow
Copy link

@wapa5pow wapa5pow commented Mar 31, 2025

Description of changes

There are translation (i18n) key mismatch for 'Incorrect username or password.'.
Some languages are not correctly set.

Issue #, if available

no Issue #

Description of how you validated changes

There is only 'Incorrect username or password.' key in source code.
Some languages are correctly set but others are not.

image

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@wapa5pow wapa5pow requested a review from a team as a code owner March 31, 2025 23:59
Copy link

changeset-bot bot commented Mar 31, 2025

⚠️ No Changeset found

Latest commit: cf8c6d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wapa5pow wapa5pow force-pushed the fix-translation-key branch from 7137e46 to 4efb159 Compare April 3, 2025 10:31
Copy link
Member

@calebpollman calebpollman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing these @wapa5pow! Left some feedback that should be easily resolved

Comment on lines -102 to 103
'Incorrect username or password':
'Incorrect username or password.':
'Falscher Benutzername oder falsches Passwort',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this key will break consumers that may be using it, even if it is erroneous. To avoid breaking potential consumers would provide the correct key and leave the incorrect key:

Suggested change
'Incorrect username or password':
'Incorrect username or password.':
'Falscher Benutzername oder falsches Passwort',
// erroneous key left in place to avoid breaking consumers
'Incorrect username or password':
'Falscher Benutzername oder falsches Passwort',
'Incorrect username or password.':
'Falscher Benutzername oder falsches Passwort',

The same approach should be supplied to the other files updated in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants