-
Notifications
You must be signed in to change notification settings - Fork 323
fix translation key mismatch #6482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
7137e46
to
4efb159
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing these @wapa5pow! Left some feedback that should be easily resolved
'Incorrect username or password': | ||
'Incorrect username or password.': | ||
'Falscher Benutzername oder falsches Passwort', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing this key will break consumers that may be using it, even if it is erroneous. To avoid breaking potential consumers would provide the correct key and leave the incorrect key:
'Incorrect username or password': | |
'Incorrect username or password.': | |
'Falscher Benutzername oder falsches Passwort', | |
// erroneous key left in place to avoid breaking consumers | |
'Incorrect username or password': | |
'Falscher Benutzername oder falsches Passwort', | |
'Incorrect username or password.': | |
'Falscher Benutzername oder falsches Passwort', |
The same approach should be supplied to the other files updated in this PR.
Description of changes
There are translation (i18n) key mismatch for 'Incorrect username or password.'.
Some languages are not correctly set.
Issue #, if available
no Issue #
Description of how you validated changes
There is only 'Incorrect username or password.' key in source code.
Some languages are correctly set but others are not.
Checklist
yarn test
passes and tests are updated/addeddocs
,e2e
,examples
, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.