Re-order the default credential providers to reduce logs and latency #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EC2 provider uniquely has to make network requests even when not configured to determine failure, whereas all the other providers can quickly fail due to missing config. This generates delay and log noise when using one of the providers listed after EC2. Reordering them should continue to be fast for all providers including EC2, and improve the performance for eks and web_identity.
onno-vos-dev
approved these changes
Oct 30, 2025
Member
onno-vos-dev
left a comment
onno-vos-dev
left a comment
There was a problem hiding this comment.
Sounds reasonable and thank you for a really good and solid description! <3
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-orders the default providers to solve a nuisance we've experienced using the eks or web_identity providers: the EC2 provider must time out before it will try using the next provider and we don't expect it to succeed.
We could certainly solve this by overriding the default providers, but it's nice to not have to in the default case.
The EC2 provider uniquely has to make network requests even when not configured to determine failure, whereas all the other providers can quickly fail due to missing config. This generates delay and log noise when using one of the providers listed after EC2. Reordering them should continue to be fast for all providers including EC2, and improve the performance for eks and web_identity.
Co-author: @slackersoft
Licensing:
This contribution is made by employees of Mechanical Orchard, Inc. under the terms of the project’s license.