add global cluster endpoint to rds-globalcluster #585
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccmlst
reviewed
Jan 15, 2025
| "description": " The storage encryption setting for the new global database cluster.\nIf you specify the SourceDBClusterIdentifier property, don't specify this property. The value is inherited from the cluster.", | ||
| "type": "boolean" | ||
| }, | ||
| "GlobalEndpoint": { |
There was a problem hiding this comment.
how is this property gets used?
There was a problem hiding this comment.
not passed in as part of the createGlobalCluster request, it is created with the global cluster
There was a problem hiding this comment.
It seems to me we need to add it as a readonly property (similar to e.g. https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-rds/blob/master/aws-rds-dbcluster/aws-rds-dbcluster.json#L436) - see https://docs.aws.amazon.com/cloudformation-cli/latest/userguide/resource-type-schema.html
readOnlyProperties
Resource properties that can be returned by a read or list request, but can't be set by the user.
We have property transforms that transform KMS key IDs into regex patterns matching the ARNs returned by the RDS API. These patterns did not work correctly in all regions, causing false drift detections to be reported. This change fixes the issue by relaxing the patterns so that they match when executed in all regions.
…t needed improving. First, all generated classes should be excluded from the report. Second, the block is applied to branch based coverage. Line based coverage shall no longer block changes. Why? A simple example: In a nested function call 'foo(bar(5))' if code is refactored to 'int x = bar(5); foo(x);' We've altered the line count and therefore the coverage ratio without any change to the code complexity or even to the AST. Branch coverage by contrast is a much closer approximation of 'has this code changed in complexity or behavior'. Thirdly, the scope of coverage is changed from PACKAGE to BUNDLE. PACKAGE makes sense for some libraries that limit interaction between package scopes. Since this repository contains deployable units (ie. lambda functions equivalent to executables) we choose to evaluate the coverage in totality. Why? A simple example is if some method is extracted across package boundaries the safety and correctness of the bundle hasn't changed but the coverage may throw a hissy fit. Overall these changes will produce a higher value signal when coverage checks do fail.
…nt styling. These settings are almost Intellij's default formatting. Future committers should ensure they use the On Save features: Reformat Code > VCS changed lines && optimize imports.
…anding the DBInstance type.
The CFN handler framework automatically handles certain exceptions and returns a failed response. Changing test_handleRequest_base to do the same.
…iguration Adds support for the automatic pause/resume feature of Aurora Serverless v2. Also bumping the AWS Java SDK to 2.29.16.
The docs folders in this repository, which are automatically generated from the JSON schema files, have now partially diverged from the official documentation on the AWS website. Removing these from the repository altogether as they continue to cause confusion to customers who find them included in search results.
…instance should not fail the CFN deploy cr: https://code.amazon.com/reviews/CR-183574965
…ndencies from aws-cloudformation-rpdk-java-plugin
…apshot And restore-db-cluster-to-point-in-time
…napshot is provided and when AccessException is thrown
…llow setting of retention period for cross-region replicated backups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Following up with the launch of global cluster endpoints https://aws.amazon.com/about-aws/whats-new/2024/10/amazon-aurora-global-database-writer-endpoint, adding global cluster endpoints to rds-global-cluster
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.