Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IAM Resource policy pattern #4040

Merged
merged 4 commits into from
Mar 19, 2025

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Mar 19, 2025

Issue #, if available:
#753
Description of changes:

  • Update IAM Resource policy pattern
  • Update rule W3037 to limit services and actions when using a resource policy
  • Add rule E3514 to validate resource policy resource ARNs

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.20%. Comparing base (dded1dc) to head (81433dd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4040   +/-   ##
=======================================
  Coverage   94.19%   94.20%           
=======================================
  Files         385      386    +1     
  Lines       13290    13318   +28     
  Branches     2630     2637    +7     
=======================================
+ Hits        12519    12546   +27     
  Misses        420      420           
- Partials      351      352    +1     
Flag Coverage Δ
unittests 94.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kddejong kddejong merged commit ce36ba7 into aws-cloudformation:main Mar 19, 2025
22 checks passed
@kddejong kddejong deleted the fix/issue/753 branch March 19, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant