Change transform check in W3037 #4041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddejong
force-pushed
the
fix/issue/4035
branch
from
0819bde to
484e151
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4041 +/- ##
==========================================
- Coverage 94.21% 94.20% -0.01%
==========================================
Files 386 386
Lines 13318 13318
Branches 2637 2637
==========================================
- Hits 12547 12546 -1
Misses 420 420
- Partials 351 352 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alex9smith
added a commit
to govuk-one-login/di-account-management-backend
that referenced
this pull request
Mar 20, 2025
In #580 we pinned to an old version of cfn-lint to avoid a bug. That bug's been fixed (see aws-cloudformation/cfn-lint#4041) so we can unpin and get the latest version. I did consider leaving the pin in place to avoid these sorts of errors in the future, but it'd add another dependency upgrade that we'd have to look for, test and upgrade manually and I vaguely remember a conversation from a while back where we decided that that wasn't worth the tradeoff.
github-merge-queue bot
pushed a commit
to govuk-one-login/di-account-management-backend
that referenced
this pull request
Mar 20, 2025
## Proposed changes Unpin cfn-lint in the PR / post-merge Github actions. ### What changed <!-- Describe the changes in detail - the "what"--> ### Why did it change In #580 we pinned to an old version of cfn-lint to avoid a bug. That bug's been fixed (see aws-cloudformation/cfn-lint#4041) so we can unpin and get the latest version. I did consider leaving the pin in place to avoid these sorts of errors in the future, but it'd add another dependency upgrade that we'd have to look for, test and upgrade manually and I vaguely remember a conversation from a while back where we decided that that wasn't worth the tradeoff. ## Testing You can install the latest version locally to verify it runs on our backend template with no errors: ```bash pip install --upgrade cfn-lint # gets the new 1.32.0 cfn-lint -t template.yaml -r "eu-west-2" # Runs with no errors ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fix #4035
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.