fix(ec2): Allow FromPort/ToPort for ICMPv6 in W3687 - #4600
Merged
Conversation
Add icmpv6 protocol variants (58, "58", "icmpv6", "ICMPv6", "ICMPV6") to the exclusion allowlist so that W3687 does not incorrectly flag FromPort/ToPort as ignored for ICMPv6 security group rules. These properties specify ICMP type and code which are valid for ICMPv6. Fixes aws/aws-cdk#38422
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4600 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 430 430
Lines 15190 15190
Branches 2921 2921
=======================================
Hits 14352 14352
Misses 459 459
Partials 379 379
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add icmpv6 protocol variants (58, "58", "icmpv6", "ICMPv6", "ICMPV6") to the exclusion allowlist so that W3687 does not incorrectly flag FromPort/ToPort as ignored for ICMPv6 security group rules. These properties specify ICMP type and code which are valid for ICMPv6.
aws/aws-cdk#38422
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.