Skip to content

Filedb improv #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
satyakigh wants to merge 2 commits into from
Closed

Filedb improv #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
717d67c
Improve EncryptedFileStore for crash safety and cross-process concurr…
satyakigh Apr 23, 2026
413e4a8
add feature flag
satyakigh Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 51 additions & 47 deletions assets/featureFlag/alpha.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,49 +1,53 @@
{
"version": 1,
"description": "Feature flags for alpha environment",
"features": {
"Constants": {
"enabled": false
},
"EnhancedDryRun": {
"enabled": true,
"fleetPercentage": 100,
"allowlistedRegions": [
"us-east-1",
"us-east-2",
"us-west-1",
"us-west-2",
"ca-central-1",
"ca-west-1",
"sa-east-1",
"mx-central-1",
"eu-north-1",
"eu-west-1",
"eu-west-2",
"eu-west-3",
"eu-central-1",
"eu-central-2",
"eu-south-1",
"eu-south-2",
"ap-east-1",
"ap-east-2",
"ap-south-1",
"ap-south-2",
"ap-northeast-1",
"ap-northeast-2",
"ap-northeast-3",
"ap-southeast-1",
"ap-southeast-2",
"ap-southeast-3",
"ap-southeast-4",
"ap-southeast-5",
"ap-southeast-7",
"me-south-1",
"me-central-1",
"af-south-1",
"il-central-1",
"test-region"
]
"version": 1,
"description": "Feature flags for alpha environment",
"features": {
"Constants": {
"enabled": false
},
"EnhancedDryRun": {
"enabled": true,
"fleetPercentage": 100,
"allowlistedRegions": [
"us-east-1",
"us-east-2",
"us-west-1",
"us-west-2",
"ca-central-1",
"ca-west-1",
"sa-east-1",
"mx-central-1",
"eu-north-1",
"eu-west-1",
"eu-west-2",
"eu-west-3",
"eu-central-1",
"eu-central-2",
"eu-south-1",
"eu-south-2",
"ap-east-1",
"ap-east-2",
"ap-south-1",
"ap-south-2",
"ap-northeast-1",
"ap-northeast-2",
"ap-northeast-3",
"ap-southeast-1",
"ap-southeast-2",
"ap-southeast-3",
"ap-southeast-4",
"ap-southeast-5",
"ap-southeast-7",
"me-south-1",
"me-central-1",
"af-south-1",
"il-central-1",
"test-region"
]
},
"FileDb": {
"enabled": true,
"fleetPercentage": 100
}
}
}
}
}
96 changes: 50 additions & 46 deletions assets/featureFlag/beta.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,48 +1,52 @@
{
"version": 1,
"description": "Feature flags for beta environment",
"features": {
"Constants": {
"enabled": false
},
"EnhancedDryRun": {
"enabled": true,
"fleetPercentage": 100,
"allowlistedRegions": [
"us-east-1",
"us-east-2",
"us-west-1",
"us-west-2",
"ca-central-1",
"ca-west-1",
"sa-east-1",
"mx-central-1",
"eu-north-1",
"eu-west-1",
"eu-west-2",
"eu-west-3",
"eu-central-1",
"eu-central-2",
"eu-south-1",
"eu-south-2",
"ap-east-1",
"ap-east-2",
"ap-south-1",
"ap-south-2",
"ap-northeast-1",
"ap-northeast-2",
"ap-northeast-3",
"ap-southeast-1",
"ap-southeast-2",
"ap-southeast-3",
"ap-southeast-4",
"ap-southeast-5",
"ap-southeast-7",
"me-south-1",
"me-central-1",
"af-south-1",
"il-central-1"
]
"version": 1,
"description": "Feature flags for beta environment",
"features": {
"Constants": {
"enabled": false
},
"EnhancedDryRun": {
"enabled": true,
"fleetPercentage": 100,
"allowlistedRegions": [
"us-east-1",
"us-east-2",
"us-west-1",
"us-west-2",
"ca-central-1",
"ca-west-1",
"sa-east-1",
"mx-central-1",
"eu-north-1",
"eu-west-1",
"eu-west-2",
"eu-west-3",
"eu-central-1",
"eu-central-2",
"eu-south-1",
"eu-south-2",
"ap-east-1",
"ap-east-2",
"ap-south-1",
"ap-south-2",
"ap-northeast-1",
"ap-northeast-2",
"ap-northeast-3",
"ap-southeast-1",
"ap-southeast-2",
"ap-southeast-3",
"ap-southeast-4",
"ap-southeast-5",
"ap-southeast-7",
"me-south-1",
"me-central-1",
"af-south-1",
"il-central-1"
]
},
"FileDb": {
"enabled": false,
"fleetPercentage": 100
}
}
}
}
}
96 changes: 50 additions & 46 deletions assets/featureFlag/prod.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,48 +1,52 @@
{
"version": 1,
"description": "Feature flags for prod environment",
"features": {
"Constants": {
"enabled": false
},
"EnhancedDryRun": {
"enabled": true,
"fleetPercentage": 100,
"allowlistedRegions": [
"us-east-1",
"us-east-2",
"us-west-1",
"us-west-2",
"ca-central-1",
"ca-west-1",
"sa-east-1",
"mx-central-1",
"eu-north-1",
"eu-west-1",
"eu-west-2",
"eu-west-3",
"eu-central-1",
"eu-central-2",
"eu-south-1",
"eu-south-2",
"ap-east-1",
"ap-east-2",
"ap-south-1",
"ap-south-2",
"ap-northeast-1",
"ap-northeast-2",
"ap-northeast-3",
"ap-southeast-1",
"ap-southeast-2",
"ap-southeast-3",
"ap-southeast-4",
"ap-southeast-5",
"ap-southeast-7",
"me-south-1",
"me-central-1",
"af-south-1",
"il-central-1"
]
"version": 1,
"description": "Feature flags for prod environment",
"features": {
"Constants": {
"enabled": false
},
"EnhancedDryRun": {
"enabled": true,
"fleetPercentage": 100,
"allowlistedRegions": [
"us-east-1",
"us-east-2",
"us-west-1",
"us-west-2",
"ca-central-1",
"ca-west-1",
"sa-east-1",
"mx-central-1",
"eu-north-1",
"eu-west-1",
"eu-west-2",
"eu-west-3",
"eu-central-1",
"eu-central-2",
"eu-south-1",
"eu-south-2",
"ap-east-1",
"ap-east-2",
"ap-south-1",
"ap-south-2",
"ap-northeast-1",
"ap-northeast-2",
"ap-northeast-3",
"ap-southeast-1",
"ap-southeast-2",
"ap-southeast-3",
"ap-southeast-4",
"ap-southeast-5",
"ap-southeast-7",
"me-south-1",
"me-central-1",
"af-south-1",
"il-central-1"
]
},
"FileDb": {
"enabled": false,
"fleetPercentage": 0
}
}
}
}
}
5 changes: 3 additions & 2 deletions src/datastore/DataStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { FeatureFlag } from '../featureFlag/FeatureFlagI';
import { Closeable } from '../utils/Closeable';
import { isWindows } from '../utils/Environment';
import { pathToStorage } from '../utils/Storage';
Expand Down Expand Up @@ -62,8 +63,8 @@ export class MultiDataStoreFactoryProvider implements DataStoreFactoryProvider {
private readonly memoryStoreFactory: MemoryStoreFactory;
private readonly persistedStore: DataStoreFactory;

constructor() {
if (isWindows) {
constructor(fileDbFeatureFlag: FeatureFlag) {
if (fileDbFeatureFlag.isEnabled() || isWindows) {
this.persistedStore = new FileStoreFactory(pathToStorage());
} else {
this.persistedStore = new LMDBStoreFactory(pathToStorage());
Expand Down
Loading
Loading