Skip to content

Switch Guard and CfnLint telemetry to emitting error type #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
satyakigh merged 1 commit into from
Apr 27, 2026
Merged

Switch Guard and CfnLint telemetry to emitting error type #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/services/cfnLint/CfnLintService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ export class CfnLintService implements SettingsConfigurable, Closeable, Readines
}
} catch (error) {
this.status = STATUS.Uninitialized;
this.telemetry.error('init.fault', error, undefined, { captureErrorAttributes: true });
this.telemetry.error('init.fault', error, undefined, { captureErrorType: true });
this.telemetry.histogram('init.duration', performance.now() - startTime, { unit: 'ms' });
throw new Error(`Failed to initialize Pyodide worker: ${extractErrorMessage(error)}`);
}
Expand Down Expand Up @@ -233,7 +233,7 @@ export class CfnLintService implements SettingsConfigurable, Closeable, Readines
this.logError('mounting folder', error);
const errorType = this.classifyLintError(error);
this.telemetry.error('mount.fault', error, undefined, {
captureErrorAttributes: true,
captureErrorType: true,
attributes: { errorType },
});
throw new MountError(`Failed to mount folder ${mountDir}`, error instanceof Error ? error : undefined);
Expand Down Expand Up @@ -331,7 +331,7 @@ export class CfnLintService implements SettingsConfigurable, Closeable, Readines
* @param uri The document URI
* @param fileType The CloudFormation file type
*/
@Count({ name: 'lint.standaloneFile', captureErrorAttributes: true })
@Count({ name: 'lint.standaloneFile', captureErrorType: true })
private async lintStandaloneFile(content: string, uri: string, fileType: CloudFormationFileType): Promise<void> {
const startTime = performance.now();
const doc = this.documentManager.get(uri);
Expand Down Expand Up @@ -364,7 +364,7 @@ export class CfnLintService implements SettingsConfigurable, Closeable, Readines
// Only count as lint.error if it's a cfn-lint failure, not infrastructure issues
if (!this.isInfrastructureError(errorType)) {
this.telemetry.error('lint.error', error, undefined, {
captureErrorAttributes: true,
captureErrorType: true,
attributes: {
fileType,
errorType,
Expand Down Expand Up @@ -409,7 +409,7 @@ export class CfnLintService implements SettingsConfigurable, Closeable, Readines
* @param fileType The CloudFormation file type
* @param content The document content (used for GitSync deployment files)
*/
@Count({ name: 'lint.workspaceFile', captureErrorAttributes: true })
@Count({ name: 'lint.workspaceFile', captureErrorType: true })
private async lintWorkspaceFile(
uri: string,
folder: WorkspaceFolder,
Expand Down Expand Up @@ -476,7 +476,7 @@ export class CfnLintService implements SettingsConfigurable, Closeable, Readines
// Only count as lint.error if it's a cfn-lint failure, not infrastructure issues
if (!this.isInfrastructureError(errorType)) {
this.telemetry.error('lint.error', error, undefined, {
captureErrorAttributes: true,
captureErrorType: true,
attributes: {
fileType,
errorType,
Expand Down
6 changes: 3 additions & 3 deletions src/services/cfnLint/PyodideWorkerManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,17 +140,17 @@ export class PyodideWorkerManager {
},
reject: (reason: Error) => {
this.worker = undefined;
this.telemetry.error('pyodide.init.fault', reason, undefined, { captureErrorAttributes: true });
this.telemetry.error('pyodide.init.fault', reason, undefined, { captureErrorType: true });

// Try to determine if it was a PyPI or wheels failure
const errorMessage = reason.message || '';
if (errorMessage.includes('PyPI')) {
this.telemetry.error('init.pypi.fault', reason, undefined, {
captureErrorAttributes: true,
captureErrorType: true,
});
} else if (errorMessage.includes('wheels') || errorMessage.includes('wheel')) {
this.telemetry.error('init.wheels.fault', reason, undefined, {
captureErrorAttributes: true,
captureErrorType: true,
});
}

Expand Down
14 changes: 7 additions & 7 deletions src/services/guard/GuardService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ export class GuardService implements SettingsConfigurable, Closeable, ReadinessC
* @param uri The document URI
* @param forceUseContent If true, always use the provided content (for consistency with CfnLintService)
*/
@Count({ name: 'validate', captureErrorAttributes: true })
@Count({ name: 'validate', captureErrorType: true })
async validate(content: string, uri: string, _forceUseContent?: boolean): Promise<void> {
const fileType = this.documentManager.get(uri)?.cfnFileType;

Expand Down Expand Up @@ -254,7 +254,7 @@ export class GuardService implements SettingsConfigurable, Closeable, ReadinessC
// Publish empty diagnostics to clear any previous Guard diagnostics
this.publishDiagnostics(uri, []);
this.telemetry.error('parser.error', error, undefined, {
captureErrorAttributes: true,
captureErrorType: true,
attributes: { errorType: 'ParseError' },
});
// Parse errors are developer issues, not service availability issues
Expand All @@ -264,7 +264,7 @@ export class GuardService implements SettingsConfigurable, Closeable, ReadinessC
// Check for WASM errors
if (errorMessage.includes('WASM') || errorMessage.includes('wasm')) {
this.telemetry.error('wasm.error', error, undefined, {
captureErrorAttributes: true,
captureErrorType: true,
attributes: { errorType: 'WasmError' },
});
}
Expand All @@ -275,13 +275,13 @@ export class GuardService implements SettingsConfigurable, Closeable, ReadinessC
errorMessage.includes('Memory') ||
errorMessage.includes('out of memory')
) {
this.telemetry.error('memory.threshold.exceeded', error, undefined, { captureErrorAttributes: true });
this.telemetry.error('memory.threshold.exceeded', error, undefined, { captureErrorType: true });
}

// For other errors (WASM issues, timeouts, etc.), log as error and show diagnostic
this.publishErrorDiagnostics(uri, errorMessage);
this.telemetry.error('validate.error', error, undefined, {
captureErrorAttributes: true,
captureErrorType: true,
attributes: { fileType, errorType: 'Unknown' },
});
} finally {
Expand Down Expand Up @@ -672,7 +672,7 @@ export class GuardService implements SettingsConfigurable, Closeable, ReadinessC
this.log.info(`Loaded ${customRules.length} rules from custom file: ${this.settings.rulesFile}`);
} catch (error) {
this.telemetry.error('rules.load.error', error, undefined, {
captureErrorAttributes: true,
captureErrorType: true,
attributes: { errorType: 'CustomFile' },
});
this.log.error(
Expand Down Expand Up @@ -711,7 +711,7 @@ export class GuardService implements SettingsConfigurable, Closeable, ReadinessC
}
} catch (error) {
this.telemetry.error('rules.load.error', error, undefined, {
captureErrorAttributes: true,
captureErrorType: true,
attributes: { pack: packName, errorType: 'PackLoad' },
});
this.log.error(`Failed to get rules for pack '${packName}': ${extractErrorMessage(error)}`);
Expand Down
Loading