Skip to content

chore: Only include the current platform in the deps bundle #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

evanspearman-a
Copy link
Contributor

What was the problem/requirement? (What/Why)

We were including all platforms when we build the dependency bundle rather than just the current platform. Other platforms aren't necessary.

What was the solution? (How)

Only include the current platform.

What is the impact of this change?

Smaller and faster installers. Less code overall.

How was this change tested?

I built the installer locally and ran it and verified I could open the Deadline Cloud dialog in Blender

Please run the integration tests and paste the results below

This change doesn't change any submitter code.

If installer/ was modified or a file was added/removed from src/, then update the installer tests and post the test results below

=================================================== test session starts ====================================================
platform win32 -- Python 3.9.13, pytest-8.3.5, pluggy-1.5.0 -- C:\Users\evans\AppData\Local\hatch\env\virtual\deadline-cloud-for-blender\8LSmqhTD\deadline-cloud-for-blender\Scripts\python.exe
cachedir: .pytest_cache
rootdir: C:\Users\evans\Development\installers-project\deadline-cloud-for-blender
configfile: pyproject.toml
plugins: cov-6.1.0, xdist-3.6.1
8 workers [13 items]    
scheduling tests via LoadScheduling

test/installer/test_installer.py::test_default_location
test/installer/test_installer.py::test_did_not_build_with_evaluation_mode 
test/installer/test_installer.py::TestLinuxAndMacOS::test_user_permissions 
test/installer/test_installer.py::TestLinuxAndMacOS::test_system_permissions 
test/installer/test_installer.py::TestWindows::test_user_permissions 
test/installer/test_installer.py::TestWindows::test_system_permissions 
test/installer/test_installer.py::TestUserInstall::test_install 
[gw5] [  7%] SKIPPED test/installer/test_installer.py::TestWindows::test_system_permissions 
[gw2] [ 15%] SKIPPED test/installer/test_installer.py::TestLinuxAndMacOS::test_user_permissions 
test/installer/test_installer.py::TestVerifySigning::test_windows_signing 
[gw2] [ 23%] SKIPPED test/installer/test_installer.py::TestVerifySigning::test_windows_signing 
test/installer/test_installer.py::TestUserInstall::test_uninstall 
[gw3] [ 30%] SKIPPED test/installer/test_installer.py::TestLinuxAndMacOS::test_system_permissions 
test/installer/test_installer.py::TestVerifySigning::test_linux_signing
[gw3] [ 38%] SKIPPED test/installer/test_installer.py::TestVerifySigning::test_linux_signing 
[gw1] [ 46%] SKIPPED test/installer/test_installer.py::test_did_not_build_with_evaluation_mode 
test/installer/test_installer.py::TestSystemInstall::test_uninstall 
[gw1] [ 53%] SKIPPED test/installer/test_installer.py::TestSystemInstall::test_uninstall 
[gw0] [ 61%] PASSED test/installer/test_installer.py::test_default_location 
test/installer/test_installer.py::TestSystemInstall::test_install 
[gw0] [ 69%] SKIPPED test/installer/test_installer.py::TestSystemInstall::test_install 
[gw4] [ 76%] PASSED test/installer/test_installer.py::TestWindows::test_user_permissions
test/installer/test_installer.py::TestVerifySigning::test_macos_signing
[gw4] [ 84%] SKIPPED test/installer/test_installer.py::TestVerifySigning::test_macos_signing
[gw6] [ 92%] PASSED test/installer/test_installer.py::TestUserInstall::test_install
[gw7] [100%] PASSED test/installer/test_installer.py::TestUserInstall::test_uninstall

=================================================== slowest 5 durations ==================================================== 
111.08s setup    test/installer/test_installer.py::TestUserInstall::test_uninstall
111.02s setup    test/installer/test_installer.py::TestUserInstall::test_install
101.11s setup    test/installer/test_installer.py::TestWindows::test_user_permissions
19.84s call     test/installer/test_installer.py::TestUserInstall::test_uninstall
5.10s call     test/installer/test_installer.py::test_default_location
========================================= 4 passed, 9 skipped in 136.49s (0:02:16) =========================================

Was this change documented?

No

Is this a breaking change?

I suppose technically you can't copy an installation to a different platform anymore any have it work.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@evanspearman-a evanspearman-a requested a review from a team as a code owner April 3, 2025 19:36
@evanspearman-a evanspearman-a added the dependencies Pull requests that update a dependency file label Apr 3, 2025
@evanspearman-a evanspearman-a force-pushed the deps branch 3 times, most recently from 09b2629 to b8e62c3 Compare April 4, 2025 16:30
Copy link

sonarqubecloud bot commented Apr 4, 2025

@epmog epmog enabled auto-merge (squash) April 4, 2025 22:32
@epmog epmog merged commit 2ee3fda into aws-deadline:mainline Apr 4, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants