Skip to content

chore: add installer operating systems and publish tag #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

epmog
Copy link
Contributor

@epmog epmog commented Apr 4, 2025

What was the problem/requirement? (What/Why)

  1. Release workflow wasn't building installers
  2. PyPI publish was using the release branch

What was the solution? (How)

  1. Add the installer operating systems to the workflow call
  2. Expose the created tag as a workflow output: feat: add newly created tag to publish_v2 workflow outputs .github#34
  3. consume the workflow output tag to checkout instead of the release branch

What is the impact of this change?

Built artifacts!

How was this change tested?

Playing a little fast/loose here, so it hasn't.

Please run the integration tests and paste the results below

N/A

Was this change documented?

N/A

Is this a breaking change?

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@epmog epmog requested a review from a team as a code owner April 4, 2025 00:35
Copy link

sonarqubecloud bot commented Apr 4, 2025

@epmog epmog merged commit c690b5f into aws-deadline:mainline Apr 4, 2025
19 of 20 checks passed
@epmog epmog deleted the add_installer_oses branch April 4, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants