chore: Determine the installer version based on Git revision and tags #224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
DCC Submitter installers get their version from an environment variable, or use "00000000" for dev builds, then add the current date on the end. Instead, installers should have versions based on repository tags. If the latest tag matches the current commit hash, the version should just be the latest tag. Otherwise, the version should be the latest tag plus the short commit hash of the current commit.
What was the solution? (How)
Change the way the installer building script determines the version to match what was described above. Additionally I added a flag for overriding the version.
What is the impact of this change?
Versions will be related to the tags.
How was this change tested?
I build the installer, ran it, and verified that installer_version.txt contained the correct version.
Please run the integration tests and paste the results below
N/A
If
installer/
was modified or a file was added/removed fromsrc/
, then update the installer tests and post the test results belowWas this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.