test: Added Adaptor integration tests to validate opening and closing of Houdini.#335
Open
erico-aws wants to merge 1 commit intoaws-deadline:mainlinefrom
Open
test: Added Adaptor integration tests to validate opening and closing of Houdini.#335erico-aws wants to merge 1 commit intoaws-deadline:mainlinefrom
erico-aws wants to merge 1 commit intoaws-deadline:mainlinefrom
Conversation
miabatta
suggested changes
Jan 20, 2026
test/integ/test_houdini_adaptors.py
Outdated
| # Stop daemon | ||
| if connection_file.exists(): | ||
| stop_cmd = [ | ||
| "blender-openjd", |
Comment on lines
+242
to
+244
| assert ( | ||
| stop_process.returncode == 0 | ||
| ), f"Daemon stop failed: {stop_process.stderr}" |
Contributor
There was a problem hiding this comment.
Should we include some kind of process cleanup if this assert fails?
Contributor
Author
There was a problem hiding this comment.
I don't think OpenJD gives us the daemon's process id, so I'm not sure that we can clean it up if this fails.
6e80c34 to
b719210
Compare
… of Houdini. Signed-off-by: Eric Osiowy <134728121+erico-aws@users.noreply.github.com>
b719210 to
1f15ae7
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What was the problem/requirement? (What/Why)
There is no integration test for checking that the adaptor can start and stop Houdini. The minimal render tests partially cover this by starting Houdini but we never check that the adaptor closes Houdini when complete.
What was the solution? (How)
Added a few tests to check starting Houdini and closing it. Cancel should close Houdini and the same behaviour should be scene when running as a daemon.
What is the impact of this change?
More confidence in the Adaptors control over the Houdini process.
How was this change tested?
Ran tests:
Please run the integration tests and paste the results below.
Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.