-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Conda recipe for RSMB 6.4.4 for After Effects, with README about plugin packaging #79
base: mainline
Are you sure you want to change the base?
Conversation
…t plugin packaging Signed-off-by: Daniel Cilevitz <[email protected]>
09b2b04
to
ae059f7
Compare
Moved from aws-deadline/deadline-cloud-for-after-effects#95 Please see previous comment thread: aws-deadline/deadline-cloud-for-after-effects#95 (comment) Merged README.md into the rsmb-6-4-4 recipe folder. |
Does this plugin depends on After Effects being installed first? Can you verify and test whether you should add AE as some kind of dependency like here? Relevant documentation for that is here: https://docs.aws.amazon.com/deadline-cloud/latest/developerguide/create-conda-recipe-mtoa-plugin.html |
# See https://docs.conda.io/projects/conda/en/latest/dev-guide/deep-dives/activation.html | ||
# for details on activation. The Deadline Cloud sample queue environments use bash | ||
# to activate environments on Windows, so we recommend always producing both .bat and .sh files. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the .sh activate/deactivate scripts are missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/aws-deadline/deadline-cloud-samples/blob/mainline/conda_recipes/aftereffects-25.0/recipe/build_win.sh#L25-L30 here is what you can use as an example.
mkdir -p "$PREFIX/etc/conda/deactivate.d" | ||
|
||
cat <<EOF > "$PREFIX/etc/conda/activate.d/$PKG_NAME-$PKG_VERSION-vars.bat" | ||
robocopy "$PREFIX/opt/rsmb" "$PREFIX/opt/aftereffects/Support Files/Plug-Ins" *.aex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This folder should be Plug-ins
not Plug-Ins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have an alternate PR that goes through how to do an AE plugin Conda recipe that's free and doesn't require licensing. Ideally we can reference that to make improvements to this PR: #88 |
What was the problem/requirement? (What/Why)
After Effects requires a project's referenced plugins to be installed onto the render machine in a location that requires elevated permissions on Windows to modify. After Effects has a version-dependent plugin path in the system registry, which also requires elevated permissions to modify. We need to install plugin files to a location that After Effects can access at render time in a service-managed fleet environment, where elevated permissions are not available.
What was the solution? (How)
We have created a workflow for producing Conda packages that dynamically install plugins into an SMF job's render environment. After Effects can then load a submitted project's referenced plugins at render time.
What is the impact of this change?
Users can add supported plugins to their render jobs so their effects will render correctly in an SMF environment.
How was this change tested?
The workflow was tested on CPU-only and GPU-accelerated service-managed fleets with RSMB 6.4.4 as the packaged plugin. We confirmed that following the workflow gets farm resources set up correctly and submitted jobs produce correct render output on Adobe After Effects 24.0 and 25.1.
Was this change documented?
Yes, there is a README.md in the recipe folder describing the workflow and its prerequisites.
Is this a breaking change?
No.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.